Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compilation progress log #2969

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Aug 22, 2024

Changes:

  1. The global flag --dev-show-thread-ids is now properly being passed. Before it was ignored.
  2. The progress log has been refactored out of the ParallelTemplate into the Pipeline.Driver. With the extra information available, I've improved how we display the progress log:
    1. We show Compiling, Recompiling, Loading to tell if the module is compiled for the first time (the jvo is missing), or it needs to be recompiled (with the reason displayed in parentheses), or is loaded from a jvo file. In the latter case, the message is only showed with --log-level verbose|debug.
    2. The modules in other packages are displayed as dependencies with their own progress counter.
  3. When using -N 1 and compiling a whole project we also get progress log.

Example screencast:

show.mp4

@janmasrovira janmasrovira self-assigned this Aug 22, 2024
@janmasrovira janmasrovira force-pushed the 2797-the-compiling-message-should-only-be-displayed-for-modules-that-are-actually-compiled branch 2 times, most recently from 46f878d to 4213461 Compare August 27, 2024 14:45
@janmasrovira janmasrovira changed the title Show only Compiling when the file needs to be recompiled Improve compilation progress log Aug 27, 2024
@janmasrovira janmasrovira added enhancement New feature or request fix:bug labels Aug 27, 2024
@janmasrovira janmasrovira force-pushed the 2797-the-compiling-message-should-only-be-displayed-for-modules-that-are-actually-compiled branch 3 times, most recently from 59baa65 to a514bfd Compare August 28, 2024 14:12
@janmasrovira janmasrovira marked this pull request as ready for review August 28, 2024 21:08
@lukaszcz lukaszcz force-pushed the 2797-the-compiling-message-should-only-be-displayed-for-modules-that-are-actually-compiled branch from 6702abe to 0da1614 Compare August 29, 2024 15:37
@janmasrovira janmasrovira merged commit eb00fa4 into main Aug 29, 2024
4 checks passed
@janmasrovira janmasrovira deleted the 2797-the-compiling-message-should-only-be-displayed-for-modules-that-are-actually-compiled branch August 29, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement New feature or request fix:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Compiling" message should only be displayed for modules that are actually compiled
2 participants