Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data subvention): try to use id rna #1484

Merged
merged 2 commits into from
Dec 27, 2024
Merged

fix(data subvention): try to use id rna #1484

merged 2 commits into from
Dec 27, 2024

Conversation

rmonnier9
Copy link
Contributor

@rmonnier9 rmonnier9 commented Dec 23, 2024 •
edited
Loading

  • Correction d'un bug.
  • Détails :
    • Récupération via l'id rna (ou siret si id rna est nulle)
    • Puis fallback sur siret
    • Correctif d'affichage (ajout de marge)

Closes #1476

Avant :
image

Après :
image

@rmonnier9 rmonnier9 requested a review from XavierJp as a code owner December 23, 2024 14:15
@rmonnier9 rmonnier9 force-pushed the fix-data-subvention-with-rnaid branch from 0e9f65f to 2e39d6e Compare December 23, 2024 14:16
XavierJp
XavierJp approved these changes Dec 27, 2024
View reviewed changes
models/subventions/association/index.ts Outdated Show resolved Hide resolved
@XavierJp XavierJp merged commit 5b4db61 into main Dec 27, 2024
8 checks passed
@XavierJp XavierJp deleted the fix-data-subvention-with-rnaid branch December 27, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierJp XavierJp XavierJp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data subvention] Fallback Id RNA vs Siren
2 participants
@rmonnier9 @XavierJp