Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e): error if api not mocked #1462

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat(e2e): error if api not mocked #1462

merged 1 commit into from
Dec 17, 2024

Conversation

rmonnier9
Copy link
Contributor

  • Amélioration technique.
  • Détails :
    • Quand cette PR pourra être déployée, toutes les requêtes vers des APIs externes auront été correctement mockées !

@rmonnier9 rmonnier9 requested a review from XavierJp as a code owner December 16, 2024 13:27
@rmonnier9 rmonnier9 changed the title feat: error if request not intercepted while e2e feat(e2e): error if api not mocked Dec 16, 2024
Copy link
Contributor

@XavierJp XavierJp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice !

@rmonnier9 rmonnier9 force-pushed the finish-remove-stub branch 2 times, most recently from e61ae7c to 7d90e69 Compare December 17, 2024 17:06
@rmonnier9
Copy link
Contributor Author

Thanks to this PR, I've detected a last route that needed to be mocked as well !
Now we are good !

@rmonnier9 rmonnier9 merged commit 60d4142 into main Dec 17, 2024
8 checks passed
@rmonnier9 rmonnier9 deleted the finish-remove-stub branch December 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants