Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR][COLTER] Refactor colter dag with DataProcessor #444

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

hacherix
Copy link
Contributor

@hacherix hacherix commented Dec 30, 2024

Related to #405

The original DAG is split into two to avoid changing the DataProcessor paradigm which should produce only one output file.

image

The data_processing_collectivite_territoriale_elus dag requires the file output from data_processing_collectivite_territoriale to run. So:

  1. data_processing_collectivite_territoriale updates the colter dataset once the compare_files_minio task succeeds.
  2. data_processing_collectivite_territoriale_elus will run anytime this dataset is "updated" knowing it can download it from the shared URL.

Note: the data_processing_collectivite_territoriale dag failure is expected since there is a known issue with a source dataset.

Copy link
Contributor

@HAEKADI HAEKADI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🚀

config.py Outdated Show resolved Hide resolved
workflows/data_pipelines/colter/colter_dag.py Outdated Show resolved Hide resolved
@hacherix hacherix force-pushed the refactor-colter-dag branch from 0ad8bb2 to 3996030 Compare December 31, 2024 11:19
The original DAG is split into two to avoid changing the DataProcessor paradigm
which should produce only one output file.

The `data_processing_collectivite_territoriale` triggers the
`data_processing_collectivite_territoriale_elus` regardless of the status
of its tasks.
@hacherix hacherix force-pushed the refactor-colter-dag branch from 3996030 to b297238 Compare December 31, 2024 11:26
@hacherix hacherix merged commit 977ba34 into main Dec 31, 2024
4 checks passed
@hacherix hacherix deleted the refactor-colter-dag branch December 31, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants