fix: improvement from code review

anninowak · Feb 26, 2024 · 5197a47 · 5197a47
1 parent 683a827
commit 5197a47
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/libs/portal-integration-angular/assets/i18n/de.json b/libs/portal-integration-angular/assets/i18n/de.json
@@ -17,7 +17,7 @@
     }
   },
   "OCX_SEARCH_CONFIG": {
-    "PLACEHOLDER": "Bitte geben Sie den Namen der Search Config ein.",
+    "PLACEHOLDER": "Bitte geben Sie den Namen der Suchkonfiguration an.",
     "SAVE_COLUMNS_OPTION": "Möchten Sie die angezeigten Spalten speichern?",
     "SAVE_INPUT_FIELDS_OPTION": "Möchten Sie die Werte aus den Suchfeldern speichern?"
   },

diff --git a/libs/portal-integration-angular/assets/i18n/en.json b/libs/portal-integration-angular/assets/i18n/en.json
@@ -17,7 +17,7 @@
     }
   },
   "OCX_SEARCH_CONFIG": {
-    "PLACEHOLDER": "Please enter the name of the search config",
+    "PLACEHOLDER": "Please enter the name of the search configuration",
     "SAVE_COLUMNS_OPTION": "Do you want to save the shown columns?",
     "SAVE_INPUT_FIELDS_OPTION": "Do you want to save the input values from the input fields?"
   },

diff --git a/...ents/create-or-edit-search-config-dialog/create-or-edit-search-config-dialog.component.ts b/...ents/create-or-edit-search-config-dialog/create-or-edit-search-config-dialog.component.ts
@@ -27,7 +27,7 @@ export class CreateOrEditSearchConfigDialogComponent
   @Input() searchConfigName: string | undefined
   @Input() saveInputValues: boolean | undefined
   @Input() saveColumns: boolean | undefined
-  @Input() placeHolderKey = 'OCX_SEARCH_CONFIG.PLACEHOLDER'
+  placeHolderKey = 'OCX_SEARCH_CONFIG.PLACEHOLDER'
   @Output() primaryButtonEnabled: EventEmitter<boolean> = new EventEmitter()
   searchConfigFormGroup: FormGroup = new FormGroup({
     searchConfigName: new FormControl<string>(''),

diff --git a/...rtal-integration-angular/src/lib/core/components/search-config/search-config.component.ts b/...rtal-integration-angular/src/lib/core/components/search-config/search-config.component.ts
@@ -14,7 +14,7 @@ export class SearchConfigComponent implements OnInit {
   @Input() placeholderKey = 'OCX_SEARCH_HEADER.OCX_SEARCH_CONFIG.DROPDOWN_DEFAULT'
 
   @Output()
-  selectedSearchConfig: EventEmitter<SearchConfig> = new EventEmitter()
+  selectedSearchConfigChanged: EventEmitter<SearchConfig> = new EventEmitter()
 
   formGroup: FormGroup | undefined
   ngOnInit(): void {
@@ -23,7 +23,7 @@ export class SearchConfigComponent implements OnInit {
     })
   }
 
-  onSearchConfigChange(event: SearchConfig) {
-    this.selectedSearchConfig?.emit(event)
+  onSearchConfigChange(searchConfig: SearchConfig) {
+    this.selectedSearchConfigChanged?.emit(searchConfig)
   }
 }
diff --git a/...al-integration-angular/src/lib/core/components/search-header/search-header.component.html b/...al-integration-angular/src/lib/core/components/search-header/search-header.component.html
@@ -4,7 +4,7 @@
   [actions]="headerActions"
 >
   <ng-template #additionalToolbarContent>
-    <ocx-search-config [searchConfigs]="searchConfigs" (selectedSearchConfig)="confirmSearchConfig($event)">
+    <ocx-search-config [searchConfigs]="searchConfigs" (selectedSearchConfigChanged)="confirmSearchConfig($event)">
     </ocx-search-config>
     <ng-container *ngIf="_additionalToolbarContent" [ngTemplateOutlet]="_additionalToolbarContent"></ng-container>
   </ng-template>

diff --git a/...rtal-integration-angular/src/lib/core/components/search-header/search-header.component.ts b/...rtal-integration-angular/src/lib/core/components/search-header/search-header.component.ts
@@ -40,7 +40,7 @@ export class SearchHeaderComponent implements AfterViewInit {
 
   @Output() searched: EventEmitter<any> = new EventEmitter()
   @Output() resetted: EventEmitter<any> = new EventEmitter()
-  @Output() selectedSearchConfig: EventEmitter<SearchConfig> = new EventEmitter()
+  @Output() selectedSearchConfigChanged: EventEmitter<SearchConfig> = new EventEmitter()
   @Output() viewModeChanged: EventEmitter<string> = new EventEmitter()
   @ContentChild('additionalToolbarContent')
   additionalToolbarContent: TemplateRef<any> | undefined
@@ -105,7 +105,7 @@ export class SearchHeaderComponent implements AfterViewInit {
     }
   }
 
-  confirmSearchConfig(event: SearchConfig) {
-    this.selectedSearchConfig?.emit(event)
+  confirmSearchConfig(searchConfig: SearchConfig) {
+    this.selectedSearchConfigChanged?.emit(searchConfig)
   }
 }