Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider explicitly handling "application/dash+xml" MIME type #20

Closed
anforowicz opened this issue Feb 12, 2021 · 4 comments · Fixed by #26
Closed

Consider explicitly handling "application/dash+xml" MIME type #20

anforowicz opened this issue Feb 12, 2021 · 4 comments · Fixed by #26

Comments

@anforowicz
Copy link
Collaborator

Should we explicitly add "application/dash+xml" to the definition of "an opaque-safelisted MIME type"?

Based on the docs for DASH Adaptive Streaming, it seems that this MIME type may be directly used in video tags. CORB had to start explicitly recognizing this MIME type in https://crbug.com/947498.

FWIW, I see that https://mimesniff.spec.whatwg.org/#audio-or-video-mime-type 1) doesn't list "application/dash+xml" and 2) also lists "application/ogg" (but this one should be covered by ORB's reference to the audio/video sniffing)
@anforowicz
Copy link
Collaborator Author

(I think that currently [without the proposed changes] the ORB algorithm would block "application/dash+xml" responses in the final step, because earlier steps would decide that the response doesn't sniff as video and doesn't sniff as JavaScript.)

@annevk
Copy link
Owner

annevk commented Feb 15, 2021

Yeah that seems reasonable. (See also whatwg/fetch#886.)

Are there web-platform-tests for this?

anforowicz added a commit to anforowicz/orb that referenced this issue Feb 25, 2021
@anforowicz
Add application/dash+xml to opaque-safelisted MIME types.
6f3d29a 
Closes annevk#20.
@anforowicz anforowicz mentioned this issue Feb 25, 2021
Closed
@anforowicz anforowicz mentioned this issue Mar 4, 2021
Closed
annevk added a commit that referenced this issue Oct 4, 2021
@annevk
Block manifest-based media and WebVTT
34cf17e 
These MIME types cannot be fetched without CORS.

Closes #20 and closes #23.

Follow-up: whatwg/html#6468.
@annevk annevk mentioned this issue Oct 4, 2021
Merged
@annevk annevk closed this as completed in #26 Oct 5, 2021
annevk added a commit that referenced this issue Oct 5, 2021
@annevk
Block manifest-based media and WebVTT
9c4bd7f 
These MIME types cannot be fetched without CORS.

Closes #20 and closes #23.

Follow-up: whatwg/html#6468.
@anforowicz anforowicz mentioned this issue Nov 1, 2021
Open
@anforowicz anforowicz reopened this Nov 12, 2021
@annevk
Copy link
Owner

annevk commented Nov 15, 2021

Do we need to keep this open now that we have #29?

@anforowicz
Copy link
Collaborator Author

You're right - it's probably best to just keep track this in #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@annevk @anforowicz