Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor loses focus when toggling list and copy selects wrong target deck for filtered decks #3465

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

cything
Copy link
Contributor

@cything cything commented Oct 1, 2024

Fixes #3391 and #3338

@dae
Copy link
Member

dae commented Oct 2, 2024

Thanks for contributing Shirish!

I've given this a test, and noticed it doesn't work correctly when the cursor is not at the bottom. For example, if you have a list of 3 elements, and the cursor is on the first, creating a list and then removing it again will move the cursor to the end. And since the current behaviour does seem to work correctly in some circumstances, this seems like a step in the wrong direction. So I'll cut that part out, and merge the other part of your PR.

@dae dae merged commit 2ac2758 into ankitects:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create Copy" selects the wrong target deck for cards in filtered decks
2 participants