Fix Mnemosyne importer chokes on due dates >= 2038 #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpnguyen107
changed the title
|
Thanks Ben! I've confirmed this fixed the issue. The main outstanding issue I'm aware of is that card.mod is an i32. It's not a pressing issue, as we don't store 1+ day intervals in seconds, but we'll need to deal with it at one point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #3428. It seems to be a well-known problem.
I haven't tested it yet though. Can you share the problematic .db with me so I can see if this fixes the problem @dae? Even if it doesn't, we probably want to keep this change thinking ahead towards 2038... It'd probably be a good idea to make sure anywhere else Unix time is used in the codebase is also at least 64 bits.