Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't ignore buried cards in future due graph #3368

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

jakeprobst
Copy link
Contributor

@jakeprobst jakeprobst commented Aug 18, 2024

the future due graph undercounts cards by a notable amount when using "Bury Review Siblings".

before
future_due_current

after
future_due_modified

but more importantly it makes the load balancer look better 🍃

Closes #1984

@jakeprobst jakeprobst force-pushed the accurate_future_due branch from 48c64cb to dc28368 Compare August 18, 2024 19:42
it does ignore them for the current day but not days in the future
@dae
Copy link
Member

dae commented Aug 22, 2024

Thanks Jake!

@dae dae merged commit 7ea573b into ankitects:main Aug 22, 2024
1 check passed
@dae
Copy link
Member

dae commented Aug 22, 2024

Re-reading the issue I linked, should we perhaps be checking for due <= 0 instead?

@jakeprobst
Copy link
Contributor Author

changing it to due <= 0 does not seem to make a difference in how the chart ends up. Though the number for today in the graph is not entirely accurate as it still misses some cards. For example for today the graph says I have 197 due but I actually have 208 due. Checking Backlog does show additional cards that would explain the difference.

To fix the thing you are thinking of I think, this would need to see if Backlog is checked and then count negative days as zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include buried cards in future due graph
2 participants