Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping the Qt5 builds #3615

Open
dae opened this issue Dec 6, 2024 · 7 comments
Open

Consider dropping the Qt5 builds #3615

dae opened this issue Dec 6, 2024 · 7 comments
Milestone

Comments

@dae
Copy link
Member

dae commented Dec 6, 2024

It might be time to start thinking about dropping the Qt5 builds. They tie us down to an old Chromium/JS version from 2019, which is becoming increasingly cumbersome to deal with as the HTML/JS ecosystem evolves, and leads to issues like #3614.

Add-on developers have had about 32 months to update their add-ons since the introduction of Qt6 at this point. Aside from the add-on stragglers, the Qt5 builds were kept around because:

  • They work on older OS versions
  • Some Mac users prefer the way windows can be displayed in tabs, which only works in Qt <= 5.14

But in order to support them, we're increasingly having to make Qt5-specific workarounds. And the dual builds make things more confusing for new users.

Thoughts?

@chrislongros
Copy link

I have not used Qt5 build since 3-4 years...

@glutanimate
Copy link
Contributor

👍 I'm for it – add-ons have had plenty of time to adapt, plus those old Chromium targets are also becoming more and more of a headache for add-on development. Would simplify test matrices and QA for add-ons as well, which I think most developers would welcome quite a bit.

@dae
Copy link
Member Author

dae commented Dec 9, 2024

Ok, as a first step I've removed mention of Qt5 from https://apps.ankiweb.net, and will drop the references in the manual. I'm about the flip the switch on an update notification, and think it's better to have this in place first, or we'll get duplicate reports for #3614.

dae added a commit to ankitects/anki-manual that referenced this issue Dec 9, 2024
@EugeneTarasenko
Copy link

Too bad. After trying both Qt5 and Qt6, Qt5 turned out to be better imho.

@Rskie
Copy link

Rskie commented Dec 11, 2024

It'd be significantly less efficient to use on mac without tabs ...

@EugeneTarasenko
Copy link

It'd be significantly less efficient to use on mac without tabs ...

Tabs are incredibly helpful when using Anki. In my opinion, this is a must-have feature!

dae added a commit that referenced this issue Dec 15, 2024
dae added a commit that referenced this issue Dec 16, 2024
@NicoleRauch
Copy link

NicoleRauch commented Dec 18, 2024

I specifically switched back to Qt5 because I experienced issues on Mac (the IME did not work correctly). Is it known whether this issue is fixed? If not, I'm afraid I won't be able to upgrade in that case.

Edit: I installed the Silicon Qt6 version anyway and so far it seems to be working fine. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants