Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

Commit

Permalink
sqlite: DbResponse: add start_index
Browse files Browse the repository at this point in the history
To avoid OOM situations, we want to return a fixed amount of memory,
rather than a fixed number of rows when querying the DB

We move to indexing into the collection of rows, rather than a fixed
per-page basis

start_index is the index into the db result where the current response
was generated from.

This is useful to ensure that the cursor's state is correct
  • Loading branch information
david-allison committed Apr 1, 2021
1 parent c597f26 commit c9e1205
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions proto/sqlite.proto
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,5 @@ message DBResponse {
DBResult result = 1;
int32 sequenceNumber = 2;
int32 rowCount = 3;
int64 startIndex = 4;
}

0 comments on commit c9e1205

Please sign in to comment.