Sched: Enable New Timezone Handling Code

[david-allison]

Purpose / Description

Anki Desktop has modified their code to better handle timezone changes. See linked issue

Fixes

Fixes #5805

Approach

Copied from Anki at commit ankitects/anki@131d37d
Except one line in Collection which accepts data if server == true.

https://github.com/ankitects/anki/blob/131d37dca52c29033432e0149052093ab1c79461/pylib/anki/collection.py
https://github.com/ankitects/anki/blob/131d37dca52c29033432e0149052093ab1c79461/pylib/anki/schedv2.py

• Bumps SYNC_VERSION to 10 if using Rust
• Add local_minutes_west and sched_timing_today to Backend
• Add "New timezone handling" preference: sets creationOffset
• Set "localOffset" preference if using SchedV2 under Rust
• Fix SchedV2:_updateCutoff to better handle timezones

We will calculate this information in the Rust in V2 of the Rust Conversion

We can't do this yet as we're still on V11 of the database schema

How Has This Been Tested?

• Compared with Anki Desktop - config variables were the same
• Unit Tested
• Syncing config did not work - investigated with help from @dae - likely cause: ankitects/anki@73679b0

Checklist

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)

[codecov]

Codecov Report

Merging #8054 (c12a438) into master (7459828) will decrease coverage by 0.02%.
The diff coverage is 46.47%.

@@             Coverage Diff              @@
##             master    #8054      +/-   ##
============================================
- Coverage     36.94%   36.92%   -0.03%     
- Complexity     3751     3766      +15     
============================================
  Files           350      352       +2     
  Lines         35736    35803      +67     
  Branches       4730     4739       +9     
============================================
+ Hits          13204    13220      +16     
- Misses        21023    21070      +47     
- Partials       1509     1513       +4     

Impacted Files	Coverage Δ	Complexity Δ
...roid/src/main/java/com/ichi2/anki/Preferences.java	11.24% <0.00%> (-0.34%)	15.00 <0.00> (ø)
...va/com/ichi2/libanki/backend/JavaDroidBackend.java	37.50% <0.00%> (-12.50%)	3.00 <0.00> (ø)
...ackend/exception/BackendNotSupportedException.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...in/java/com/ichi2/libanki/sched/AbstractSched.java	50.00% <ø> (ø)	5.00 <0.00> (ø)
...id/src/main/java/com/ichi2/libanki/Collection.java	52.01% <40.00%> (+0.04%)	165.00 <0.00> (+1.00)
...2/libanki/backend/model/SchedTimingTodayProto.java	60.00% <60.00%> (ø)	1.00 <1.00> (?)
...src/main/java/com/ichi2/libanki/sched/SchedV2.java	81.45% <63.63%> (-0.79%)	405.00 <8.00> (+6.00)	⬇️
...iDroid/src/main/java/com/ichi2/libanki/Consts.java	75.00% <100.00%> (+8.33%)	1.00 <0.00> (ø)
...com/ichi2/libanki/backend/DroidBackendFactory.java	76.92% <100.00%> (+4.19%)	5.00 <0.00> (+1.00)
...va/com/ichi2/libanki/backend/RustDroidBackend.java	68.75% <100.00%> (+14.90%)	7.00 <2.00> (+3.00)
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7459828...c12a438. Read the comment docs.

[mikehardy]

This looks cool! Starting to get some features courtesy of rust :-)
I had one note that was code structure, I didn't see anything off in general, so this LGTM pending that
You ready to merge this, as in you feel like the initial conversion is solid enough to throw this in on top? I would not hesitate personally but you're the one watching issue flow I'm sure
As such, I think you merge + release on your preference to control same - either immediately if you like or whatever delay you prefer if so

[david-allison]

Oh, also could use a quick skim over ankidroid/Anki-Android-Backend@edbac00

[david-allison]

Force pushed to remove conflicts - unsure what the "waiting for feedback" label was for.

[mikehardy]

All LGTM

[mikehardy]

Ready at your leisure for merge + release