Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle database-related errors / import in AnkiActivity #17512

Merged
merged 4 commits into from
Nov 29, 2024
Merged

fix: handle database-related errors / import in AnkiActivity #17512

merged 4 commits into from
Nov 29, 2024

Commits on Nov 29, 2024

  1. fix: sendExceptionReport even if Dialog display fails 

    previously we would ignore our sendExceptionReport param if a dialog
post fails, meaning that we would not get exception reports from ACRA
in circumstances we really want them
    @mikehardy
    mikehardy committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    4c00e78 View commit details
    Browse the repository at this point in the history

  2. test: new dev pref to set collection path to pre-scoped storage 

    this patch has been floating around a lot, and it is very useful
you can use it to test the permanently inaccessible storage dialog,
which you can then also use to test the restore from backup dialog
    @mikehardy
    mikehardy committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    0ea48e7 View commit details
    Browse the repository at this point in the history

  3. chore: these are expected errors and we have no trouble recovering fr… 

    …om them

so we do not need the full stack trace and they shouldn't be warn
    @mikehardy
    mikehardy committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    36851ed View commit details
    Browse the repository at this point in the history

  4. fix: handle database-related errors / import in AnkiActivity 

    this removes all the casting to DeckPicker that causes crashes at
the worst possible time (like when you lost collection permission
and the PermissionActivity is not a DeckPicker type)
    @mikehardy
    mikehardy committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    1a5dcaf View commit details
    Browse the repository at this point in the history