Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump com.vanniktech:android-image-cropper from 4.5.0 to 4.6.0 #16824

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 5, 2024

Bumps com.vanniktech:android-image-cropper from 4.5.0 to 4.6.0.

Release notes

Sourced from com.vanniktech:android-image-cropper's releases.

4.6.0

Changelog

Sourced from com.vanniktech:android-image-cropper's changelog.

Version 4.6.0 (2024-08-05)

Commits
  • 8b020e9 Prepare version 4.6.0
  • 7eb3191 API: Deprecate CropImageContract. (#637)
  • 1f892e4 API: Deprecate CropImageActivity. (#635)
  • e5424e9 API: CropImageOptions#canChangeCropWindow option. (#636)
  • a25c2c8 Documentation: Update README. (#633)
  • 6aebb15 Technical: Update to Kotlin 2.0.0 & more. (#634)
  • 65aaa62 Technical: Update all the dependencies. (#628)
  • 80c12e5 Add language (#606)
  • d382c97 Gradle: Use Java 11, Android Gradle Plugin 8.0.2 & update all dependencies. (...
  • 6bcf718 Fixed bug when changing toolbar text color (#556)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies used for automated dependency PRs label Aug 5, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w: file:///home/runner/work/Anki-Android/Anki-Android/AnkiDroid/src/main/java/com/ichi2/utils/ImageUtils.kt:52:13 'constructor(uri: Uri?, cropImageOptions: CropImageOptions): CropImageContractOptions' is deprecated. This ActivityResultContract is deprecated.

Please either roll your own ActivityResultContract with the desired behavior or copy paste this.

@criticalAY not GSOC related, but in your area if you have time

@criticalAY criticalAY self-assigned this Aug 5, 2024
@david-allison
Copy link
Member

david-allison commented Aug 5, 2024

Asked about the rationale:


From the README: CropView is the only non-deprecated method

NB: Linked sample 404s

2. Using CropView

Note: This is the only way forward, add CropImageView into your own activity and do whatever you wish. Checkout the sample for more details.

<!-- Image Cropper fill the remaining available height -->
<com.canhub.cropper.CropImageView
  android:id="@+id/cropImageView"
  android:layout_width="match_parent"
  android:layout_height="0dp"
  android:layout_weight="1"
  />
  • Set image to crop
cropImageView.setImageUriAsync(uri)
// Or prefer using uri for performance and better user experience.
cropImageView.setImageBitmap(bitmap)
  • Get cropped image
// Subscribe to async event using cropImageView.setOnCropImageCompleteListener(listener)
cropImageView.getCroppedImageAsync()
// Or.
val cropped: Bitmap = cropImageView.getCroppedImage()

https://github.com/CanHub/Android-Image-Cropper?tab=readme-ov-file#2-using-cropview


From our Discord:

It will be quite some work but I have setup most of it rn, so can take it to the finish line, their sample is usable but I will remove the buttons and add menu so that it matches the current UI

by @criticalAY

@dependabot dependabot bot force-pushed the dependabot/gradle/dependency-updates/com.vanniktech-android-image-cropper-4.6.0 branch from 36efe4a to a1fd037 Compare August 15, 2024 23:26
@mikehardy
Copy link
Member

Just a note for me mostly: will be obsoleted by:

@dependabot dependabot bot force-pushed the dependabot/gradle/dependency-updates/com.vanniktech-android-image-cropper-4.6.0 branch from a1fd037 to a6e5756 Compare August 16, 2024 03:12
@mikehardy
Copy link
Member

@dependabot rebase

Bumps [com.vanniktech:android-image-cropper](https://github.com/CanHub/Android-Image-Cropper) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/CanHub/Android-Image-Cropper/releases)
- [Changelog](https://github.com/CanHub/Android-Image-Cropper/blob/main/CHANGELOG.md)
- [Commits](CanHub/Android-Image-Cropper@4.5.0...4.6.0)

---
updated-dependencies:
- dependency-name: com.vanniktech:android-image-cropper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/dependency-updates/com.vanniktech-android-image-cropper-4.6.0 branch from a6e5756 to 9f827c7 Compare August 31, 2024 00:01
@mikehardy
Copy link
Member

@dependabot rebase

once more :-)

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 31, 2024

Looks like this PR is already up-to-date with dependency-updates! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mikehardy mikehardy closed this Aug 31, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 31, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/dependency-updates/com.vanniktech-android-image-cropper-4.6.0 branch August 31, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies used for automated dependency PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants