Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC'24] Refactor: use prefill value in integer dialog #16745

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

criticalAY
Copy link
Contributor

Purpose / Description

This PR refactor IntegerDialog class to handle use case in

We want to allow the current cloze number to be displayed in the dialog input box

How Has This Been Tested?

Locally

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY changed the title refactor: use prefill value in integer dialog [GSoC'24] Refactor: use prefill value in integer dialog Jul 16, 2024
@criticalAY criticalAY added Needs Review GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors labels Jul 16, 2024
@criticalAY criticalAY added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 16, 2024
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 17, 2024
@lukstbit lukstbit added this pull request to the merge queue Jul 17, 2024
Merged via the queue into ankidroid:main with commit 4bdef47 Jul 17, 2024
11 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Jul 17, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants