[GSoC'24] Refactor DeckPicker to Single Menu Layout #16425

SanjaySargam · 2024-05-18T14:52:14Z

Purpose / Description

This PR aims to

Convert deckpicker to have single menu
Remove StudyOptionsFragment when collection is empty
Remove back button when fragmented

Approach

Moved menu items from DeckPicker screen to StudyOptionsFragment

How Has This Been Tested?

Emulator

deck_picker.mp4

Chromebook
Screen recording 2024-05-22 11.08.56.webm

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

david-allison

Could you split out the functional commits (hiding the fragment on onboarding) to make this easier to review and understand

I would have expected that the combination of menus would mean:

Remove the menu from the fragment
Have the activity control the menu, and select different menus depending on the fragment state

Is there a reason you didn't pick this implementation?

david-allison · 2024-05-24T12:49:24Z

AnkiDroid/src/main/java/com/ichi2/anki/Sync.kt

@@ -353,13 +354,13 @@ fun DeckPicker.shouldFetchMedia(preferences: SharedPreferences): Boolean {
 }

 suspend fun monitorMediaSync(
-    deckPicker: DeckPicker
+    context: Context


Why not make this an Activity if it's necessary

Not able to access from fragment ( StudyOptionsFragment )

I'm sorry @SanjaySargam but I don't understand your answer. What can't access from, and how is StudyOptionsFragment related to this code change?

R.id.action_sync -> { val actionProvider = MenuItemCompat.getActionProvider(item) as? SyncActionProvider if (actionProvider?.isProgressShown == true) { launchCatchingTask { monitorMediaSync(requireContext()) } } else { (activity as DeckPicker).sync() } return true }

@Arthur-Milchior , I called this function from fragment

Actually, you can access the DeckPicker from StudyOptionsFragment.kt. You already do it many time. It's just activity as DeckPicker

So you may not even need to change this function.

I agree with David however. We can just request it to be an Activity. We never actually need it to specifically be a DeckPicker.

SanjaySargam · 2024-05-24T13:55:19Z

Is there a reason you didn't pick this implementation?

If I do so, then the context menu ( three dots ) will show in the middle of the screen. I just thought having the menu at the top-right of the screen would be better so that's why I combined menus in fragment

SanjaySargam · 2024-05-24T14:03:36Z

I didn't quite understand your comment about splitting out the functional commits. Could you please explain it again or provide more details?

Arthur-Milchior · 2024-05-26T12:04:18Z

If I understand correctly David request, that means you'd split your PR into multiple commit.
The first commit would just take care of empty collection and remove the second fragment
the second commit would remove the back button when fragmented.
The third would move the menu from one fragment to the other

This way, it becomes far easier for us to review each commit, and consider whether it actually does what it is supposed to do

SanjaySargam · 2024-05-26T12:06:06Z

Now understood very well

Arthur-Milchior · 2024-05-26T13:18:22Z

AnkiDroid/src/main/res/menu/study_options_fragment.xml

    xmlns:ankidroid="http://schemas.android.com/apk/res-auto" >
    <item
-        android:id="@+id/action_undo"
+        android:id="@+id/action_undo1"


Please, use names that are more meaningful.
In this case action_undo_study_options and you can rename the other one action_undo_deck_picker

Why do you need to have a different ID, while the items belows seems to be fine sharing the id of deck_picker ?

Arthur-Milchior · 2024-05-26T13:20:45Z

AnkiDroid/src/main/res/menu/study_options_fragment.xml

@@ -46,4 +47,69 @@
        android:id="@+id/action_unbury"
        android:title="@string/unbury"
        android:visibility = "gone"/>
+    <group android:id="@+id/allItems" android:visible="false">


My understanding is that this is a copy/paste of deck_picker content, right ?

I don't like to have duplicated code. Because, if one day we update one of the menu, we may forget to update the other one.

Instead, in StudyOptionsFragment.kt, after toolbar!!.inflateMenu(R.menu.study_options_fragment) you can add toolbar!!.inflateMenu(R.menu.deck_picker), and you'll have the content of deck_picker.xml at the end of study_option_fragment

My understanding is that this is a copy/paste of deck_picker content, right ?

Yes

Instead, in StudyOptionsFragment.kt, after toolbar!!.inflateMenu(R.menu.study_options_fragment) you can add toolbar!!.inflateMenu(R.menu.deck_picker), and you'll have the content of deck_picker.xml at the end of study_option_fragment

I've done this, but the issue which I'm facing rn is search icon is showing in two screens ( DeckPicker & StudyOptionsFragment ) even when I explicitly hide the search icon in the fragment. Also the export menu is already there in fragment so I'm trying to hide export menu which is there in deck_picker.xml but still visible

I think, Sanjay, that you'll have to learn to give far more context in your text.
"Right now" seems strange to me. I don't know what "right now" refers to the code in your PR? Whether it refers to origin/main.
In all cases, I don't really understand what you mean here. I can't find any way to get two search icons. And I don't see it in your video.

Similarly, "the export menu is already there in fragment". There are two fragments so it was not clear to me which one you referred to, and I had to take a look to see it's in both fragments. It would be easier for me if you stated "both" directly

Instead, in StudyOptionsFragment.kt, after toolbar!!.inflateMenu(R.menu.study_options_fragment) you can add toolbar!!.inflateMenu(R.menu.deck_picker), and you'll have the content of deck_picker.xml at the end of study_option_fragment

@Arthur-Milchior I implemented the way you said. Please review it

Arthur-Milchior · 2024-05-28T20:42:25Z

I've a small problem right now with your code when I execute it.
If you start on a fresh install, just after AnkiDroid asks you to grant access to storage, you start with a split view, and then a second later, you get a single view.
On the one paw, that's not that bad, because it'll occur only the first time you open ankidroid. On the other paw, that's exactly the time where we want to have a single view because the collection is empty. And that would even be worse because that will be the first thing the user see when they open the app on tablet.

I think the issue is that you only know whether you need to display one or two views once the collection is loaded. And obviously, it can't be loaded until permissions are given.
This does not seems to be an issue with the play variant. Probably because there is need for permission.

So, we need to decide what to do when we don't have access to the collection. That is, what to put in the screen before the collection is loaded. Whether there is one or two view by default.
The simplest solution, in my mind, would be to use a preference, as they will be imediately accessible, to recall whether we used to have content last time the collection was opened. It's default value would be "empty". And it would be set to non-empty when any behavior occurs to add a deck.
I'd love opinions of other maintainers, because that seems to be a lot of code complexity for something that will be a rare problem

Arthur-Milchior

There are still quite some improvements to do. I admit I really need more information and more context in order to really understand what you tried, what failed, and most importantly, why you did the change you did.

Please don't hesitate to message me on discord if you have questions about my remark.

I still believe we can avoid that much code duplication.

Arthur-Milchior · 2024-05-28T21:56:17Z

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

@@ -2072,7 +2087,10 @@ open class DeckPicker :
        Timber.i("Updating deck list UI")
        hideProgressBar()
        // Make sure the fragment is visible
-        if (fragmented) {
+        if (fragmented && collectionIsEmpty) {


I'd have a small preference for

if (fragmented) if (collectionIsEmpty) { studyoptionsFrame!!.visibility = View.GONE invalidateOptionsMenu() } else { studyoptionsFrame!!.visibility = View.VISIBLE } }

I'd find the logic more readable.

if (fragmented) { invalidateOptionsMenu() studyoptionsFrame?.visibility = if (collectionIsEmpty) View.GONE else View.VISIBLE }

I've done this way, by the considering the case where you have only one deck and you deleted that deck, then the fragment will remove. And when we perform "undo delete deck" , the fragment will show but the optionsMenu is not updating

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

Arthur-Milchior · 2024-05-28T22:33:08Z

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

                menu.findItem(R.id.action_rename).isVisible = true
                menu.findItem(R.id.action_delete).isVisible = true
                menu.findItem(R.id.action_export).isVisible = true
+                (activity as DeckPicker).setupMediaSyncMenuItem(menu)


If we use (activity as DeckPicker) that much, I suggest we introduce private val deckPicker = activity as DeckPicker and we use it everywhere. That'll be more readable I expect

Arthur-Milchior · 2024-05-28T22:36:21Z

AnkiDroid/src/main/java/com/ichi2/anki/Sync.kt

@@ -353,13 +354,13 @@ fun DeckPicker.shouldFetchMedia(preferences: SharedPreferences): Boolean {
 }

 suspend fun monitorMediaSync(
-    deckPicker: DeckPicker
+    context: Context


Actually, you can access the DeckPicker from StudyOptionsFragment.kt. You already do it many time. It's just activity as DeckPicker

So you may not even need to change this function.

I agree with David however. We can just request it to be an Activity. We never actually need it to specifically be a DeckPicker.

Arthur-Milchior · 2024-05-28T22:47:15Z

AnkiDroid/src/main/res/menu/study_options_fragment.xml

@@ -46,4 +47,69 @@
        android:id="@+id/action_unbury"
        android:title="@string/unbury"
        android:visibility = "gone"/>
+    <group android:id="@+id/allItems" android:visible="false">


I don't like that "allItems" does not contains all items from the menu. Is there a better way of describing what it contains ?

Can we rename it as "secondaryActions"?

Arthur-Milchior · 2024-05-28T22:55:06Z

AnkiDroid/src/main/res/menu/deck_picker.xml

+        android:title="@string/search_decks"
+        android:visible="false"
+        ankidroid:actionViewClass="androidx.appcompat.widget.SearchView"
+        ankidroid:showAsAction="always|collapseActionView"/>
    <group android:id="@+id/allItems">


If we were to move the first element, I'd like the group to be renamed, as it's not "all item" anymore.
Also, I'd appreciate if you could explain in the commit message why you moved this item.
Generally, it'd be nice if you could explain the reason of any non-straightforward change in your commit message. And this is really not a change for which I can guess the meaning.

In particular, it seems that

Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

Line 975 in c2bb60d

menu.setGroupVisible(R.id.allItems, optionsMenuState != null)

won't do any anymore to the filter, which seems quite a strange change to me

Why was this comment ignored? I admit I'm still confused by the name allItems that don't contain all items.

Can we rename it as "commonItems"?

Arthur-Milchior

Did you test your code also on small screen?
Because, we should not change anything on phone. And it seems your commit is doing some change. And actually, the orange icon and the empty line of code cause ankidroid to crash.

Please don't hesitate to ask if you don't know how to debug it. Otherwise, I'd love if you could also have something that still works on android.

Appart from that, I mostly have small remarks concerning the style. It's still hard to review because last commit does a lot of things that are vaguely related. I really want to have some simple commits that do the renaming/introducing a value, that help read the code without any functional change.
And separately THE commit that do the actual functional change, that contains nothing but the functional change.

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

Arthur-Milchior · 2024-06-09T02:26:19Z

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

@@ -363,6 +363,8 @@ class StudyOptionsFragment : Fragment(), ChangeManager.Subscriber, Toolbar.OnMen
                icon!!.isAutoMirrored = true
                toolbar!!.navigationIcon = icon
                toolbar!!.setNavigationOnClickListener { (activity as AnkiActivity).finish() }
+            } else {


I'd appreciate if your commit message could contains slightly more details, so that I can understand what it does without having to read the code.

In this case, it would indicates that the button had no effect, and should not have been here in the first place.

Unless I'm wrong, this was a mistake in AnkiDroid, that was not related to the current PR.
I'd be fine putting it as a separate PR that could be merged very quickly.

This was a mistake in AnkiDroid. I'll make separate PR

Arthur-Milchior · 2024-06-09T02:32:25Z

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

            updateUndoLabelFromState(menu.findItem(R.id.action_undo), undoLabel)
            updateSyncIconFromState(menu.findItem(R.id.action_sync), this)
            menu.findItem(R.id.action_scoped_storage_migrate).isVisible = shouldShowStartMigrationButton
            setupMigrationProgressMenuItem(menu, mediaMigrationState)
        }
    }

+    private fun updateSearchFromState(menu: Menu) {


Maybe, rename to updateSearchVisibilityFromState to be more specific.
Because, when I read the part of the code where the method is used, I was wondering whether it was updating the search result, the search field or anything else.

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

Arthur-Milchior · 2024-06-09T02:47:30Z

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

@@ -81,6 +81,10 @@ class StudyOptionsFragment : Fragment(), ChangeManager.Subscriber, Toolbar.OnMen
    private lateinit var textTotal: TextView
    private var toolbar: Toolbar? = null

+    @VisibleForTesting
+    var createMenuJob: Job? = null
+    private lateinit var deckPicker: DeckPicker


My bad, I gave you a wrong snippet in the previous remark.

What I was suggesting was

/** Current activity.*/ private val deckPicker: DeckPicker get() = activity as DeckPicker

I'd consider putting it in its own commit.
The last commit is long enough, removing from the diff all lines where you use this value would simplify reviewing it

Arthur-Milchior · 2024-06-09T02:49:15Z

AnkiDroid/src/main/res/menu/study_options_fragment.xml

@@ -1,7 +1,7 @@
 <menu xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:ankidroid="http://schemas.android.com/apk/res-auto" >
    <item
-        android:id="@+id/action_undo"
+        android:id="@+id/action_undo_study_options"


Similarly, to simplify reviewing the commit, I'd considering renaming the id in its own commit. So that I can concentrate on the important part of the review without having to see all those changes.

You can do multiple renaming in a single commit.

It is not possibble to rename in separate commit . If I do so, we will get an error because action_undo id contains in deck_picker menu and studyoptions menu

Arthur-Milchior · 2024-06-09T02:50:53Z

AnkiDroid/src/main/res/menu/deck_picker.xml

+        android:title="@string/search_decks"
+        android:visible="false"
+        ankidroid:actionViewClass="androidx.appcompat.widget.SearchView"
+        ankidroid:showAsAction="always|collapseActionView"/>
    <group android:id="@+id/allItems">


Why was this comment ignored? I admit I'm still confused by the name allItems that don't contain all items.

Arthur-Milchior

All of my remarks are related to documentation/comment and can be handled later.
I tested on smartphone and tablet simulator, and it seems to work as expected. So I'm fine approving it

Arthur-Milchior · 2024-06-18T02:35:44Z

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

                return true
            }
-            else -> return false
+            // item was handled by the Deck Picker, no need to handle it here.


I'm sorry, but this comment is not right anymore.
It was right with the code snippet I gave above. Where we first tried deckPicker.onOptionsItemSelected(item). This comment explained what we were doing, and why we did an early return.

I'm totally fine with your new code. But you need to update the comment, to explain that the entry is not specific to study options, and so we delegate it to the deck picker

Arthur-Milchior · 2024-06-18T02:40:59Z

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

                menu.findItem(R.id.action_rename).isVisible = true
                menu.findItem(R.id.action_delete).isVisible = true
                menu.findItem(R.id.action_export).isVisible = true
+
+                // Add export collection item in export menu and remove it from menu


I think you should add quote around "export collection", because it's not part of the normal grammar of the sentence, and it's not clear you are referring to a string.

More generally, this is a place that may be confusing to someone who has no idea what's going on, who didn't follow this work. So I think it really would be nice to give far more context. Explaining that the "export collection" action appears in the menu directly when we only display the deck picker, but, when we display the splitted view, we want to move it to a submenu that already contains "export deck".

Arthur-Milchior · 2024-06-18T02:51:37Z

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

@@ -81,6 +81,13 @@ class StudyOptionsFragment : Fragment(), ChangeManager.Subscriber, Toolbar.OnMen
    private lateinit var textTotal: TextView
    private var toolbar: Toolbar? = null

+    @VisibleForTesting
+    var createMenuJob: Job? = null


Please add a comment. Explain why it's necessary to have this value. How you intend to use it in test. That's not clear to me

How you intend to use it in test.

@Arthur-Milchior
Really don't know, I just copied it from deckpicker . And I see createMenuJob is not used in any of the test.
Should I remove @VisibleForTesting?

Yes please remove it. Either it'll break the build, and we'll understand why it was here. Or, more probably, it'll clean up some code

Arthur-Milchior · 2024-06-18T02:52:44Z

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

+
+                deckPicker.setupMediaSyncMenuItem(menu)
+                deckPicker.updateMenuFromState(menu)
+                createMenuJob = launchCatchingTask {


Same here. It'd be nice to write down while you save this job in a member. It's not directly clear from reading the code

david-allison · 2024-06-18T09:18:08Z

I think it's unusual that the menus for the fragmented view are the responsibility of the fragment on the right, as it adds complexity to the logic

I would expect the menu to be extracted out of the fragments, and extended to the full width of the activity (with the activity being responsible)

You would then have two menu files for the DeckPicker (fragmented/non), and one for the Options (non-fragmented), and not need to worry about conditionally applying text, or moving some of the processing to the fragment

Is there a technical reason why my hunch won't work out?

SanjaySargam · 2024-06-20T17:02:51Z

@david-allison Would it be acceptable to handle this as a TODO and merge as it is? I will work on this during GSOC period only

david-allison · 2024-06-20T17:13:50Z

It would, add a to-do and let's get this in

Arthur-Milchior

Fine by me. Only a very small nit. I'd be fine merging it as-is

Arthur-Milchior · 2024-07-01T14:56:52Z

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

@@ -81,6 +81,13 @@ class StudyOptionsFragment : Fragment(), ChangeManager.Subscriber, Toolbar.OnMen
    private lateinit var textTotal: TextView
    private var toolbar: Toolbar? = null

+    @VisibleForTesting
+    var createMenuJob: Job? = null


Yes please remove it. Either it'll break the build, and we'll understand why it was here. Or, more probably, it'll clean up some code

david-allison

Only a couple of string-related changes. The implementation looks good

Think about the ordering of this menu, and see if you can improve it

AnkiDroid/src/main/res/values/01-core.xml

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

david-allison

Cheers

david-allison · 2024-07-08T12:52:26Z

Updated strings from Crowdin 2024/07/08 12:51 #16705

github-actions · 2024-07-08T14:09:21Z

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

github-actions · 2024-09-15T22:18:06Z

Hi there @SanjaySargam! This is the OpenCollective Notice for PRs merged from 2024-07-01 through 2024-07-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

Important

PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

SanjaySargam added the GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors label May 18, 2024

SanjaySargam force-pushed the deckpicker branch 2 times, most recently from 299cfaf to aa849fa Compare May 18, 2024 17:17

SanjaySargam marked this pull request as ready for review May 18, 2024 18:12

SanjaySargam added the Needs Review label May 18, 2024

david-allison requested changes May 24, 2024

View reviewed changes

Arthur-Milchior reviewed May 26, 2024

View reviewed changes

SanjaySargam force-pushed the deckpicker branch from aa849fa to 3d9c3ed Compare May 28, 2024 16:02

Arthur-Milchior reviewed May 28, 2024

View reviewed changes

SanjaySargam force-pushed the deckpicker branch from 3d9c3ed to 234dfa0 Compare May 29, 2024 16:43

david-allison self-requested a review May 29, 2024 17:28

SanjaySargam force-pushed the deckpicker branch from 234dfa0 to aaf4a5e Compare May 29, 2024 17:56

Arthur-Milchior reviewed Jun 9, 2024

View reviewed changes

SanjaySargam force-pushed the deckpicker branch from aaf4a5e to 09f72d5 Compare June 11, 2024 08:07

SanjaySargam requested a review from Arthur-Milchior June 11, 2024 08:15

Arthur-Milchior approved these changes Jun 18, 2024

View reviewed changes

Arthur-Milchior added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jun 18, 2024

SanjaySargam force-pushed the deckpicker branch from 09f72d5 to db20ac9 Compare June 18, 2024 07:47

github-actions bot added the Has Conflicts label Jun 18, 2024

SanjaySargam force-pushed the deckpicker branch from db20ac9 to afa6c2f Compare June 21, 2024 07:07

Arthur-Milchior approved these changes Jul 1, 2024

View reviewed changes

SanjaySargam force-pushed the deckpicker branch from afa6c2f to e214224 Compare July 2, 2024 06:47

Arthur-Milchior removed the Has Conflicts label Jul 2, 2024

david-allison requested changes Jul 5, 2024

View reviewed changes

AnkiDroid/src/main/res/values/01-core.xml Outdated Show resolved Hide resolved

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt Outdated Show resolved Hide resolved

SanjaySargam added 2 commits July 5, 2024 23:19

hide fragment when collection is empty

55bea62

simplify deckpicker with unified menu

0098eca

SanjaySargam force-pushed the deckpicker branch from e214224 to 0098eca Compare July 5, 2024 18:11

SanjaySargam requested a review from david-allison July 5, 2024 18:12

david-allison approved these changes Jul 8, 2024

View reviewed changes

david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) Strings and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 8, 2024

david-allison added this pull request to the merge queue Jul 8, 2024

Merged via the queue into ankidroid:main with commit f17e059 Jul 8, 2024
8 checks passed

github-actions bot added this to the 2.19 release milestone Jul 8, 2024

github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 8, 2024

This was referenced Sep 16, 2024

DeckPicker should handle menu responsibility instead of StudyOptionsFramgment (Tablet) #17077

Closed

Menu handled by DeckPicker instead of StudyOptionsFragment #17099

Closed

[GSoC'24] Refactor DeckPicker to Single Menu Layout #16425

[GSoC'24] Refactor DeckPicker to Single Menu Layout #16425

Conversation

SanjaySargam commented May 18, 2024 • edited Loading

Purpose / Description

Approach

How Has This Been Tested?

Checklist

david-allison left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjaySargam May 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjaySargam commented May 24, 2024

SanjaySargam commented May 24, 2024

Arthur-Milchior commented May 26, 2024

SanjaySargam commented May 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjaySargam May 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjaySargam May 29, 2024 • edited Loading

Choose a reason for hiding this comment

Arthur-Milchior commented May 28, 2024

Arthur-Milchior left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjaySargam Jun 9, 2024 • edited Loading

Choose a reason for hiding this comment

Arthur-Milchior left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Arthur-Milchior left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjaySargam Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

david-allison commented Jun 18, 2024 • edited Loading

SanjaySargam commented Jun 20, 2024

david-allison commented Jun 20, 2024

Arthur-Milchior left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

david-allison left a comment

Choose a reason for hiding this comment

david-allison left a comment

Choose a reason for hiding this comment

david-allison commented Jul 8, 2024

github-actions bot commented Jul 8, 2024

github-actions bot commented Sep 15, 2024

SanjaySargam commented May 18, 2024 •

edited

Loading

SanjaySargam May 26, 2024 •

edited

Loading

SanjaySargam May 27, 2024 •

edited

Loading

SanjaySargam May 29, 2024 •

edited

Loading

SanjaySargam Jun 9, 2024 •

edited

Loading

SanjaySargam Jun 18, 2024 •

edited

Loading

david-allison commented Jun 18, 2024 •

edited

Loading