[GSoC'24] Highlight selected preference setting

[SanjaySargam]

Purpose / Description

In tablet mode, the selected settings preference category is not highlighted. It would be better if we highlight the preference to have better user experience.

Approach

Highlight GeneralSettings preference as default
use onPreferenceTreeClick function and remove highlight from previously selected preference and highlight the current preference

How Has This Been Tested?

Emulator

highlight.mp4

Chromebook
Screen recording 2024-05-19 11.47.35.webm

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[BrayanDSO]

Haven't tested, but I think that this doesn't handle configuration changes (e.g. toggling night mode)

[SanjaySargam]

It handles, I consider highlighting in night mode too

[BrayanDSO]

Tested it myself, and it doesn't.

1. Use a tablet/large screen device
2. Open settings
3. Choose a section other than General
4. Toggle system's night mode

Result: General is highlighted instead of the active preference

---

Also, please avoid deleting your own comments. Editing is a more healthy choice for discussions.

[SanjaySargam]

Now I understood what you said. Sorry I didn't test this. I'll make changes accordingly.

Also, please avoid deleting your own comments. Editing is a more healthy choice for discussions

Ok will take care of this from next time

[lukstbit]

The current code has two issues:

• on phones(where the majority of our users are) the highlight shouldn't appear as it looks weird. You could fix this by making the Preferences.hasLateralNavigation() method public and then checking its status in highlightHeaderPreference() and return immediately if false(on phones).
• second issue: tablet on any orientation -> highlight one preference -> rotate the tablet -> highlight is gone

[SanjaySargam]

on phones(where the majority of our users are) the highlight shouldn't appear as it looks weird. You could fix this by making the Preferences.hasLateralNavigation() method public and then checking its status in highlightHeaderPreference() and return immediately if false(on phones).

hasLateralNavigation function is not included in companion object so we can't access even if we make it public

[lukstbit]

LGTM if it includes the change below.

[SanjaySargam]

Also tested on Chromebook

[david-allison]

minor nitpicks, should be good to go next round

[david-allison]

Cheers!

[github-actions]

Hi there @SanjaySargam! This is the OpenCollective Notice for PRs merged from 2024-05-01 through 2024-05-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

Important

PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!