Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for getting data for import csv #11761

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

krmanik
Copy link
Member

@krmanik krmanik commented Jul 2, 2022

Pull Request template

Purpose / Description

New Import CSV UI will be used for importing csv/tsv file. So, getNotetypeNamesRaw, getDeckNamesRaw, and getCsvMetadataRaw needed in V16 backend (newBackend).

Fixes

Fixes Link to the issues.

Approach

For each backend function wrapped in function with input of type ByteArray and return type of ByteArray.

How Has This Been Tested?

No test added for it but I have tested locally using this PR krmanik#23

Learning (optional, can help others)

krmanik#23

Checklist

Please, go through these checks before submitting the PR.

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@krmanik krmanik added the Review High Priority Request for high priority review label Jul 2, 2022
@krmanik
Copy link
Member Author

krmanik commented Jul 2, 2022

More methods need to add, when submit button click then data sent to backend, so need implementation. Needs improvement.

@krmanik krmanik marked this pull request as draft July 2, 2022 15:58
@krmanik krmanik marked this pull request as ready for review July 3, 2022 06:51
@lukstbit lukstbit added the Needs Second Approval Has one approval, one more approval to merge label Jul 5, 2022
@Arthur-Milchior Arthur-Milchior merged commit b6e6efd into ankidroid:main Jul 11, 2022
@github-actions github-actions bot removed Needs Second Approval Has one approval, one more approval to merge Review High Priority Request for high priority review labels Jul 11, 2022
@github-actions github-actions bot added this to the 2.16 release milestone Jul 11, 2022
@github-actions
Copy link
Contributor

Hi there @krmanik! This is the OpenCollective Notice for PRs merged from 2022-07-01 through 2022-07-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please note that GSoC contributions are okay for this process. Our philosophy is that our users have donated to AnkiDroid for all contributions. The only PRs that will not go through the OpenCollective process are ones directly related to am accepted GSoC project from a selected participant, since those receive a stipend from GSoC itself.

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants