Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSOC] Implemented Service to store Deck Meta Data #11487
[GSOC] Implemented Service to store Deck Meta Data #11487
Changes from all commits
30684d9
35f2c01
139b02c
328e52e
a7a1c60
44907df
59023e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific exception you want to catch?
If
contains
fail, I think it's okay to fail the program, something goes so wrong that it's not worth taking this into consideration.If
contains
return true but we can't actually access the data, same.So I'd put everything that consists in accessing the data outside the try, and just let the reading of the value in the
try
since it's the only one where it slightly makes sense to eventually expect an exception, after all, we are parsing text.