Tell the users why card type deletion fails when this would orphan note

[Arthur-Milchior]

An orphan note is a note that has no card. For example if you have a basic and reverse card, with only the front filled, and you delete the first card type, then the note has no card left.
In AnkiDroid/src/main/java/com/ichi2/anki/CardTemplateEditor.kt, when the user tries to delete a card type, if that would cause orphan, we stop the user from doing it, thanks to deletionWouldOrphanNote
Except that the user does not know why it failed.
We should add a simple message dialog explaining that some note would not have any card anymore.

You can imitate the lines above, where the user gets a message stating that there is a single card type and so it can't be deleted

(I should note that, in anki, we can create orphan. There is no warning. The orphan first disappear from the browser if it's opened, and then reappear if you close and reopen it.
Honestly, I prefer the way ankidroid handle it, but if a maintainer prefer to imitate anki, fine)

[HUN-sp]

@Arthur-Milchior Would love to work on this issue .

[Arthur-Milchior]

Go for it. Sorry, it seems I can't assign from GitHub Android app

[HUN-sp]

Like? I am on it sir @Arthur-Milchior

[Sahil-Mandal15]

@Arthur-Milchior is this issue still open, can this be assigned to me and can I create a pull request for my fix?

[Arthur-Milchior]

@HUN-sp Can you please give us an update ? David asked you to close one of the PR and rebase and force push the other.
If you've not done in in 48 hours, then I'll assign it to @Sahil-Mandal15. It's supposed to be a short task, if it's not updated in a week already, I think it's okay to consider those PR as abandonned

[Sahil-Mandal15]

@Arthur-Milchior I have my initial fix ready for the issue, I will create a PR when this is assigned to me.

[HUN-sp]

Hey @Arthur-Milchior assign it to sahil

…

On Tue, 6 Aug, 2024, 11:59 Sahil-Mandal15, ***@***.***> wrote: @Arthur-Milchior <https://github.com/Arthur-Milchior> I have my initial fix ready for the issue, I will create a PR when this is assigned to me. — Reply to this email directly, view it on GitHub <#16789 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDBYM26K3U4XA5A4N43II4TZQBUNDAVCNFSM6AAAAABLSXXKDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZQGQ4DIMJXGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Sahil-Mandal15]

@Arthur-Milchior I am waiting for the issue to be assigned to me to create the PR or should I proceed with it?

[Arthur-Milchior]

@Sahil-Mandal15 you could have proceeded. Of course, you're now assigned anyway.
Our goal here is just to ensure that we don't waste work, not to follow strict procedural rules. Given that HUN-sp mentioned they would let you work on it, and nobody else wanted it, it was perfectly to start

[devharsh2k4]

Is it still open?