[Bug] In Edit tags window, hierarchical tags are not shown at the top

[user1823]

The feature already exists in Desktop. I think (but not sure) that it should be easy to implement using the new backend.

Regardless of whether this is implemented or not, please hide the Edit tags option when multiple cards are selected because this option makes sense only when a single card is selected.

The actual issue is described in #15278 (comment)

[david-allison]

This should have been handled in the linked PR (Edit tags should handle multiselect), could you expand on the issues you're having (I don't use the feature myself)

• feat: Edit tags of a multiple notes / deck #8751

[user1823]

Edit implies that you can both add and remove tags. If the selected cards already have tags (and that too different ones), then it is not clear (until you try it out) what happens when you select a new tag without changing anything else (because the existing tags are not shown unless they are common to all the selected cards).

[user1823]

There are two ways to solve this issue:

1. Adopt Anki's approach of using two separate options (add and remove).
2. Adopt the approach proposed in Adding tags to deck/multiple notes #4911 (comment)

Anki's approach is more intuitive and probably easier to maintain (because of shared code).

The second approach requires the user to know what the symbols mean and what happens when they click on the "indeterminate" icon. But after they know it, this approach makes it easy to perform more complex operations.

[user1823]

Based on the linked PR, the second approach should be already implemented. But, I don't see the "indeterminate" icon when some tag is not present in all of the selected cards.

Perhaps, there is some other issue? Maybe the same root cause as #15196?

[BrayanDSO]

(because of shared code).

just FYI, this is not always the case. If it is something strict to Qt's UI, we don't get it. Only backend stuff and HTML pages

[user1823]

Still needs investigation

[david-allison]

@user1823 could you provide a screen recording when feasible, the issue isn't immediately clear to me

[user1823]

In trying to reproduce the issue in a fresh profile, I think that I have uncovered the actual issue.

I don't see the "indeterminate" icon when some tag is not present in all of the selected cards.

This happens only when hierarchical tags are used.

Actually, the indeterminate icon is there but, unlike the non-hierarchical tags, these tags are not brought to the top of the list when editing the tags. So, if I have hundreds/thousands of tags, I would not be able to find them and assume that they were not highlighted.

In the following recording, I first click edit tags on the individual cards to show tags applied to them. Then, I select both and click edit tags to show that AnkiDroid doesn't bring the hierarchical tags to the top.

screen-20240423-173514.mp4