Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Unlike Anki Desktop, trying to delete Default deck doesn't delete its notes #11703

Closed
4 tasks done
dorrin-sot opened this issue Jun 26, 2022 · 2 comments · Fixed by #11740
Closed
4 tasks done

[Bug] Unlike Anki Desktop, trying to delete Default deck doesn't delete its notes #11703

dorrin-sot opened this issue Jun 26, 2022 · 2 comments · Fixed by #11740
Labels
Anki Ecosystem Compatibility
Milestone
2.16 release

Comments

@dorrin-sot
Copy link
Contributor

Reproduction Steps
  1. If Default deck is empty, create some notes in it
  2. Tap and hold Default deck
  3. Choose "Delete deck"
Expected Result

All notes inside it would be deleted and then the error "The default deck can't be deleted" is shown

Actual Result

Only the error "The default deck can't be deleted" is shown

Research
  • I have read the support page and am reporting a bug or enhancement request specific to AnkiDroid
  • I have checked the manual and the FAQ and could not find a solution to my issue
  • I have searched for similar existing issues here and on the user forum
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
@Prince-kushwaha
Copy link
Contributor

@mikehardy can i work on this issue

@mikehardy
Copy link
Member

@Prince-kushwaha sure! Can you please do me a favor and double-check that anki desktop does actually do exactly what is described? Just to make sure - I don't use it personally and this involves destruction of user data (with the delete) so making sure is worth it. Then absolutely

dae added a commit to ankitects/Anki-Android that referenced this issue Jun 30, 2022
@dae
Support deleting/undoing deck from deck picker
6a08c44 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
dae added a commit to ankitects/Anki-Android that referenced this issue Jun 30, 2022
@dae
Support deleting/undoing deck from deck picker
12c2b12 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
@dae dae mentioned this issue Jun 30, 2022
Merged
dae added a commit to ankitects/Anki-Android that referenced this issue Jun 30, 2022
@dae
Support deleting/undoing deck from deck picker
2e6d415 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
dae added a commit to ankitects/Anki-Android that referenced this issue Jul 2, 2022
@dae
Support deleting/undoing deck from deck picker
1a56cc3 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
dae added a commit to ankitects/Anki-Android that referenced this issue Jul 6, 2022
@dae
Support deleting/undoing deck from deck picker
c5d0f1b 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
dae added a commit to ankitects/Anki-Android that referenced this issue Jul 6, 2022
@dae
Support deleting/undoing deck from deck picker
38ee531 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
dae added a commit to ankitects/Anki-Android that referenced this issue Jul 6, 2022
@dae
Support deleting/undoing deck from deck picker
9158f9c 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
dae added a commit to ankitects/Anki-Android that referenced this issue Jul 11, 2022
@dae
Support deleting/undoing deck from deck picker
5db957f 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
dae added a commit to ankitects/Anki-Android that referenced this issue Jul 16, 2022
@dae
Support deleting/undoing deck from deck picker
f5cf75c 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
dae added a commit to ankitects/Anki-Android that referenced this issue Jul 18, 2022
@dae
Support deleting/undoing deck from deck picker
6df5efb 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
dae added a commit to ankitects/Anki-Android that referenced this issue Jul 21, 2022
@dae
Support deleting/undoing deck from deck picker
18eb265 
+ Delete the cards inside the default deck if user tries to delete it

Closes ankidroid#11703
mikehardy pushed a commit that referenced this issue Jul 22, 2022
@dae @mikehardy
Support deleting/undoing deck from deck picker
eb333d3 
+ Delete the cards inside the default deck if user tries to delete it

Closes #11703
@github-actions github-actions bot added this to the 2.16 release milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Anki Ecosystem Compatibility
Projects
None yet
Milestone
2.16 release
3 participants
@mikehardy @dorrin-sot @Prince-kushwaha