Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump sqlite from 2.1.0 to 2.2.0 #177

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

mikehardy
Copy link
Member

@mikehardy mikehardy commented Apr 20, 2022

We want the new version of the sqlite dependency but

...it requires compileSdkVersion 31
...which requires JDK11
...which requires newer Android SDK commandline tools (used to install NDK)

So,

  • switch our NDK github actions install method to setup-ndk - should work
  • switch our JDK to 11 in github actions and enforce it
  • then switch sqlite versions and Android API

Variables are at least extracted so may be modified in one spot See #154 and #153 - possible easily because of #176

@mikehardy mikehardy added the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Apr 20, 2022
@mikehardy
Copy link
Member Author

Did not realize we were still on JDK8 here, while API31 requires JDK11, added a commit before the API31 bump to move to JDK11

@mikehardy
Copy link
Member Author

I forgot Android SDK bundled command line tools don't work with JDK11 🤦 what a yak shave
Added different NDK install method so we don't need sdkmanager

@mikehardy mikehardy force-pushed the sqlite-2.2 branch 4 times, most recently from 9f88326 to a00a1e2 Compare April 21, 2022 20:16
@mikehardy
Copy link
Member Author

Built on #178 now, will rebase+push after it succeeds (assuming it succeeds) but this gets a run through CI in the meantime

requires compileSdkVersion 31
@mikehardy mikehardy removed the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Apr 22, 2022
@mikehardy mikehardy merged commit e300c30 into ankidroid:main Apr 22, 2022
@mikehardy mikehardy deleted the sqlite-2.2 branch April 29, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant