Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing custom date formatting for google charts and highcharts #11

Closed
wants to merge 1 commit into from

Conversation

alterx
Copy link

@alterx alterx commented Oct 27, 2013

Following up with the issue #10 I raised a couple of days ago I'm submitting this pull request.

These changes allow custom date formatting for both highcharts and google charts.

@ankane
Copy link
Owner

ankane commented Oct 29, 2013

Awesome, thanks for the pull request. I'll try it out when I get a chance.

How consistent is the format string between Google Charts and Highcharts? For instance, if I want to show "Jan 1, 2014", will dateFormat be the same for both?

@alterx
Copy link
Author

alterx commented Oct 29, 2013

Awesome, and about consistency sadly the formats used by Highcharts differ from the ones used by Google Charts.

Google Charts: https://developers.google.com/chart/interactive/docs/reference#dateformatter
Highcharts: http://api.highcharts.com/highcharts#xAxis.dateTimeLabelFormats

@alterx
Copy link
Author

alterx commented Nov 23, 2013

Hey @ankane , just making a follow up on this request, have you had the chance to give it a look?

@ankane
Copy link
Owner

ankane commented Nov 25, 2013

Hey, sorry it's been so long - thanks for the reminder. I'll revisit it this week.

@alterx
Copy link
Author

alterx commented Dec 4, 2013

Awesome @ankane , did you have the chance to review it?

@ankane
Copy link
Owner

ankane commented Dec 6, 2013

Apologies again. Putting tooltips aside for now, I simplified it down to this. Does this work for you?

master...date_format

@alterx
Copy link
Author

alterx commented Dec 6, 2013

It certainly works, sir.

Thank you @ankane :D

@noreaster
Copy link

Did this change end up in the master branch?
It would be nice to be able to format the dates in the tooltips. I'm using the ruby version, and it's been pretty good to me so far. Thanks for your work!

@alterx
Copy link
Author

alterx commented Mar 10, 2014

I think this never actually got into the master branch @noreaster

@ptdev
Copy link

ptdev commented Mar 30, 2014

👍 This should be added

@aouji
Copy link

aouji commented Jun 30, 2014

Any chance this will get merged?

@NikAlexander
Copy link

I would like to customize the date below my horizontal axis to look like this:

"Aug, 23 24 25 26 27"

Am I able to set the month to only the first number as shown above?

@halilim
Copy link

halilim commented May 17, 2015

Ping...

@thekeenant
Copy link

This one works with master #39

@alterx alterx closed this Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants