Fix performance on Ruby 3.0 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile generated by extconf.rb has changed in Ruby 3.0. Therefore, when using Ruby 3.0, the optimization flags are not set properly and it reduced the performance. This patch will set optimization flags in compiling properly. - Here is Ruby 2.7 Makefile result: ``` CXXFLAGS = $(CCDLFLAGS) -g -O2 -std=c++1z -Wno-register $(ARCH_FLAG) ``` - Here is Ruby 3.0 Makefile result: ``` CXXFLAGS = $(CCDLFLAGS) -std=c++1z -Wno-register $(ARCH_FLAG) ``` This PR will fix anilmaurya#20 issue.
|
Thanks @Watson1978 for raising this PR, somehow I missed to notice this PR before. Will review it sometime soon. |
|
Thank you @Watson1978 once again for sending this PR. 🏅 I released version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile generated by extconf.rb has changed in Ruby 3.0.
Therefore, when using Ruby 3.0, the optimization flags are not set properly and it reduced the performance.
This patch will set optimization flags in compiling properly.
This PR will fix #20 issue.