net: defer self.destroy calls to nextTick #1
+81
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote tests for the suggested fix in nodejs#48771 (comment) Fixes: nodejs#48771
anilhelvaci
force-pushed
the
fix-48771-net-exception-with-tests
branch
from
c8694f5
to
4725298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote tests for the suggested fix in nodejs#48771 (comment)
Fixes: nodejs#48771
What is the problem being solved?
#XXX Reported
requestobject returned fromhttp.requestmethod cannot catcherrorevents triggered when there’s an immediate failure trying to connect to an address returned from dns lookup.Solution
#PR implemented changes suggested in #Comment. However the pr_number couldn’t be merged due to lack of tests(#commet-test-request). In this PR, I apply the same fix but with some tests.
Testing Considerations
All
process.nextTick(() => self.destroy())are hit except one.