Skip to content

Commit

Permalink
drm/vc4: Fix a framebuffer reference leak on async flip interrupt.
Browse files Browse the repository at this point in the history
We'd need X to queue up an async pageflip while another is
outstanding, and then take a SIGIO.  I think X actually avoids sending
out the next pageflip while one's already queued, but I'm not sure.

Signed-off-by: Eric Anholt <[email protected]>
  • Loading branch information
anholt committed Feb 26, 2016
1 parent 81f70ba commit 48627eb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/vc4/vc4_crtc.c
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,7 @@ static int vc4_async_page_flip(struct drm_crtc *crtc,
/* Make sure all other async modesetes have landed. */
ret = down_interruptible(&vc4->async_modeset);
if (ret) {
drm_framebuffer_unreference(fb);
kfree(flip_state);
return ret;
}
Expand Down

0 comments on commit 48627eb

Please sign in to comment.