💥🐛Change DataMember ordering to 1-indexed

[angularsen]

Related #1200
Fixes #1356

Apparently, protobuf-net does not support 0-indexed order values.

Some investigation indicates that the actual order value is not important, only the relative ordering.
#1356 (comment)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2424307) 84% compared to head (6319b5f) 84%.

Additional details and impacted files

@@            Coverage Diff             @@
##           release/v6   #1360   +/-   ##
==========================================
  Coverage          84%     84%           
==========================================
  Files             299     299           
  Lines           32775   32775           
==========================================
  Hits            27610   27610           
  Misses           5165    5165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[angularsen]

@lipchev You originally added the data contract support. Do you have any insight on whether this change would be safe? The relative order is preserved, but it now starts with Order=1 instead of Order=0.

• WCF should tolerate this, according to its docs. Protobuf-Net support not working because of DataMember order 0 #1356 (comment)
• Binary formatters hopefully only care about relative ordering and thus still compatible?
  • Protobuf-net, it never worked and should be OK
  • BinaryFormatter is obsolete and generally not recommended for years, so hopefully no users are affected
  • A bunch of others exist too, haven't looked into how they handle this
• XML/JSON serializers should tolerate any order, can't imagine it breaking these?

@Brunni For your information

[lipchev]

@lipchev You originally added the data contract support. Do you have any insight on whether this change would be safe? The relative order is preserved, but it now starts with Order=1 instead of Order=0.

* WCF should tolerate this, according to its docs. [Protobuf-Net support not working because of DataMember order 0 #1356 (comment)](https://github.com/angularsen/UnitsNet/issues/1356#issuecomment-1900278438)

* Binary formatters hopefully only care about relative ordering and thus still compatible?
  
  * Protobuf-net, it never worked and should be OK
  * [BinaryFormatter](https://learn.microsoft.com/en-us/dotnet/api/system.runtime.serialization.formatters.binary.binaryformatter?view=net-8.0) is obsolete and generally not recommended for years, so hopefully no users are affected
  * A bunch of others exist too, haven't looked into how they handle this

* XML/JSON serializers should tolerate any order, can't imagine it breaking these?

@Brunni For your information

I'm not aware of any possible issues with this- personally I've only ever used the Order for display purposes (and have often had members start with an Order>0 without any issues).

[angularsen]

@lipchev Thanks!

[schalpat]

Hi, I tested this PR within my grpc based project, it works for me. With the 5.42.0 public release, the transferred quantities are always zero. With the library of this PR I get the correct values. Thanks for this. Do you know when an alpha release is coming?

[angularsen]

By all accounts and from what I've mustered to find in docs, it seems like this should be a safe change.
I'll release it as a pre-release on v5 to unblock you, but unless I hear any noise in the short term, it'll land in stable v5 soon.