Add Kilo prefix to yards #1339
Merged
Add Kilo prefix to yards #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks perfect to me! Nuget should be out shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a pull request to add a "kilo" prefix to yards (similar to kilofeet). 1kyd = 1000yd. It's not a common measurement, but is needed in a project where I use UnitsNet. See the bottom paragraph of this Wikipedia article for an example of where this is practically used.
The instructions for adding a new unit mentioned adding a comment to the KiloyardsInOneMeter getter in LengthTests.cs about the number's source. I didn't see that on any other getters in this file, so I left it out to be consistent. I can add a source if needed.