Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImperialQuart to Volume #1254

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

Eternali
Copy link
Contributor

@Eternali Eternali commented Jun 2, 2023

No description provided.

/// <summary>
/// https://www.legislation.gov.uk/uksi/1995/1804/made
/// </summary>
protected override double ImperialQuartsInOneCubicMeter => 879.876993196;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified.

Weird, wolfram normally is very precise, but seems to round here.
https://www.wolframalpha.com/input?i=1+cubic+meter+in+imperial+quarts

"SingularName": "ImperialQuart",
"PluralName": "ImperialQuarts",
"FromUnitToBaseFunc": "{x} * 1.1365225e-3",
"FromBaseToUnitFunc": "{x} / 1.1365225e-3",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

The imperial quart, which is used for both liquid and dry capacity, is equal to one quarter of an imperial gallon, or exactly 1.1365225 liters.

https://en.wikipedia.org/wiki/Quart

@angularsen angularsen merged commit 3bd016a into angularsen:master Jun 2, 2023
@angularsen
Copy link
Owner

Looks perfect, thanks.
We could also add US quarts, if you are up for it? Merging this as-is anyway.

@Eternali
Copy link
Contributor Author

Eternali commented Jun 2, 2023

Thank you for the quick response!
Looks like U.S. quarts is already part of the Volume class which is why I only needed to add the Imperial quart.

@angularsen
Copy link
Owner

Lol, it was literally right next to it and I still missed it 😅

Nuget should be out shortly.
Release UnitsNet/5.17.0 · angularsen/UnitsNet

@Eternali
Copy link
Contributor Author

Eternali commented Jun 5, 2023

No problem lol, glad I wasn't missing anything, thanks for the release!

@Eternali Eternali deleted the AddImperialQuart branch June 5, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants