-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Molar Mass #303
Comments
It definitely fits in the library, perhaps it would be worthwhile to add "Amount of substance" (with the SI unit Mole) at the same time? See this page for a description on how to add new quantities. |
So you suggest to create a new quantity type "AmountOfSubstance" with a unit "Mole", am I right? I agree that it's a good idea to implement this before other molar based quantities. About the naming: I think "SubstanceAmount" is better instead of "AmountOfSubstance". What do you think? |
On the phone, but this all sounds good to me. I also see there is pound
mole unit maybe worth adding.
About naming, I leave that to you domain experts. AmountOfSubstance is my
preference solely based on that is the naming used in wiki.
…On Thu, Oct 26, 2017, 17:20 Ferit Tunçer ***@***.***> wrote:
So you suggest to create a new quantity type "AmountOfSubstance" with a
unit "Mole", am I right?
I agree that it's a good idea to implement this before other molar based
quantities.
About the naming: I think "SubstanceAmount" is better instead of
"AmountOfSubstance". What do you think?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#303 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAwFaHDI_T2qwTspG1TEl2t6Uzwqntf0ks5swKMfgaJpZM4QGdWs>
.
|
together with my colleague @ferittuncer, we are modelling a thermodynamic library for a several chemical species. To be able to freely change unit frame, we need to have a
MolarMass
quantity type data on hands.For this purpose we propose to contribute to the library by including this type.
Waiting for feedbacks. Best regards
The text was updated successfully, but these errors were encountered: