Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Molar Mass #303

Closed
gratestas opened this issue Oct 25, 2017 · 3 comments
Closed

Request: Molar Mass #303

gratestas opened this issue Oct 25, 2017 · 3 comments

Comments

@gratestas
Copy link
Contributor

together with my colleague @ferittuncer, we are modelling a thermodynamic library for a several chemical species. To be able to freely change unit frame, we need to have a MolarMass quantity type data on hands.

For this purpose we propose to contribute to the library by including this type.

Waiting for feedbacks. Best regards

@eriove
Copy link
Contributor

eriove commented Oct 26, 2017

It definitely fits in the library, perhaps it would be worthwhile to add "Amount of substance" (with the SI unit Mole) at the same time?

See this page for a description on how to add new quantities.

@0xferit
Copy link
Contributor

0xferit commented Oct 26, 2017

So you suggest to create a new quantity type "AmountOfSubstance" with a unit "Mole", am I right?

I agree that it's a good idea to implement this before other molar based quantities.

About the naming: I think "SubstanceAmount" is better instead of "AmountOfSubstance". What do you think?

@angularsen
Copy link
Owner

angularsen commented Oct 26, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants