This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
fix(Compiler): Fix zombie nodes of template->deferred #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
added a commit
that referenced
this pull request
Aug 11, 2018
tl;dr: There is a compiler optimization that tries to detect if `ViewContainerRef` is every used for a given `<template>`, and if not, avoids some code paths. That causes problems for `@deferred`, which is more or less `*deferred`, with special compiler handling. This treats deferred templates the same as `<template *ngIf>`, which fixes the phantom DOM issue of #1539. Additionally, added a race-condition fix around the deferred libraries being loaded _after_ the parent view was created. Closes #1539. Closes #1562. PiperOrigin-RevId: 208284237
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A longer description and discussion on #1539.
Closes #1539.