Add geckodriver, related config, and flags. #88
Conversation
| @@ -47,16 +48,19 @@ opts[STANDALONE] = new Option( | |||
| STANDALONE, 'Install or update selenium standalone', 'boolean', StandAlone.isDefault); | |||
| opts[CHROME] = | |||
| new Option(CHROME, 'Install or update chromedriver', 'boolean', ChromeDriver.isDefault); | |||
| opts[GECKO] = new Option(GECKO, 'Install or update geckodriver', 'string', GeckoDriver.isDefault); | |||
There was a problem hiding this comment.
the 3rd argument should then be 'boolean'
heathkit
changed the title
| @@ -133,6 +133,11 @@ function start(options: Options) { | |||
| args.push('-Dwebdriver.chrome.logfile=' + chromeLogs); | |||
| } | |||
| } | |||
| if (downloadedBinaries[GeckoDriver.id] != null) { | |||
| args.push( | |||
| '-Dwebdriver.gecko.driver=' + | |||
|
Please fix the commit message and fix conflicts. |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
heathkit
force-pushed
the
add-geckodriver
branch
from
79b525e to
c6ddaec
Compare
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
heathkit
force-pushed
the
add-geckodriver
branch
from
c6ddaec to
f440426
Compare
|
Note that this fixes #52 |
- change http.ServerResponse to http.IncomingMessage - update scripts to clean up dist and downloads before transpiling files.
geckodriver is still a little experimental, so I've disabled it by default. You need "marionette: true" in your capabilities in order to use it. Also, there's a bug where after we delete the session at the end of the test, geckodriver won't run again so you need to restart selenium.