fix(responses): response xml and json files #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cnishina
commented
May 4, 2017
cnishina
commented
- on clean, remove responses
- on update, if the size is 0 then get a new response
cnishina
force-pushed
the
fix_responses
branch
3 times, most recently
from
33dc652 to
a739eca
Compare
- on clean, remove responses - on update, if the size is 0 then get a new response
heathkit
approved these changes
May 5, 2017
| @@ -169,8 +170,13 @@ export abstract class GithubApiConfigSource extends JsonConfigSource { | |||
| try { | |||
| let contents = fs.readFileSync(fileName).toString(); | |||
| let timestamp = new Date(fs.statSync(fileName).mtime).getTime(); | |||
| let size = fs.statSync(fileName).size; | |||
There was a problem hiding this comment.
Why not fs.existsSync()? Not a big deal, just seems clearer.
There was a problem hiding this comment.
readFileSync would throw if the file does not exist. The file exists but the file is empty. I think I could also do let size = contents.length;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.