-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI should impose stricter standers on commits containing version bumps #167
Labels
Comments
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 1, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 1, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 1, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 1, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds Removed travis tests since circle tests are cooler anyway
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 1, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds Removed travis tests since circle tests are cooler anyway
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 1, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds Removed travis tests since circle tests are cooler anyway
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 1, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds Removed travis tests since circle tests are cooler anyway Made some timeouts longer because I guess circle is slow. Also improved some an error path in downloader because it was a problem while debugging. Sample output: https://circleci.com/gh/sjelin/webdriver-manager/31
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 1, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds Removed travis tests since circle tests are cooler anyway Made some timeouts longer because I guess circle is slow. Also improved some an error path in downloader because it was a problem while debugging. Sample output: https://circleci.com/gh/sjelin/webdriver-manager/31 Closes angular#165
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 16, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds Removed travis tests since circle tests are cooler anyway Made some timeouts longer because I guess circle is slow. Also improved some an error path in downloader because it was a problem while debugging. Sample output: https://circleci.com/gh/sjelin/webdriver-manager/31 Closes angular#165
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 16, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds Removed travis tests since circle tests are cooler anyway Made some timeouts longer because I guess circle is slow. Also improved some an error path in downloader because it was a problem while debugging. Sample output: https://circleci.com/gh/sjelin/webdriver-manager/31 Closes angular#165
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this issue
Dec 16, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See angular#167 for ideas about work arounds Removed travis tests since circle tests are cooler anyway Made some timeouts longer because I guess circle is slow. Also improved some an error path in downloader because it was a problem while debugging. Sample output: https://circleci.com/gh/sjelin/webdriver-manager/31 Closes angular#165
sjelin
added a commit
that referenced
this issue
Dec 21, 2016
Sadly, x86 emulation is impossible (no hardware extensions on circle) and arm is unworkably slow, so no android tests. See #167 for ideas about work arounds Removed travis tests since circle tests are cooler anyway Made some timeouts longer because I guess circle is slow. Also improved some an error path in downloader because it was a problem while debugging. Sample output: https://circleci.com/gh/sjelin/webdriver-manager/31 Closes #165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As we've discussed in person, e2e android CI tests are impossible on circle and travis. Still, here's a proposal for requiring
npm test
be run on version bumps:require('package.json').version
fromHEAD
andHEAD^
npm test
(and related CI commands) should ensure the following:master
:git diff-tree --no-commit-id --name-only -r HEAD
shows the only files changed arepackage.json
,CHANGELOG.md
, andnpm-test-history.json
(more on that last file in a second), andpackage.json
has only had itsversion
changednpm test
passes, we do the following:currentHash
isgit rev-parse HEAD
if this isn't a version bump,git rev-parse HEAD^
if this isnpm-test-history.json
equalgit rev-parse HEAD^
This wouldn't be as good as real android CI, but it would stop us from releasing any bugs. It would also provide a clear log of the last time
npm test
was run on each OSThe text was updated successfully, but these errors were encountered: