fix(gecko): Respect versions.gecko in start command. (#184)

Also bump the geckodriver version to latest.
angular · Jan 4, 2017 · 6f9a2ab · 6f9a2ab
1 parent 0dae035
commit 6f9a2ab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/config.json b/config.json
@@ -2,7 +2,7 @@
   "webdriverVersions": {
     "selenium": "2.53.1",
     "chromedriver": "2.26",
-    "geckodriver": "v0.11.1",
+    "geckodriver": "v0.12.0",
     "iedriver": "2.53.1",
     "androidsdk": "24.4.1",
     "appium": "1.6.0"

diff --git a/lib/cmds/start.ts b/lib/cmds/start.ts
@@ -26,6 +26,7 @@ let prog = new Program()
                .addOption(Opts[Opt.AVD_PORT])
                .addOption(Opts[Opt.VERSIONS_STANDALONE])
                .addOption(Opts[Opt.VERSIONS_CHROME])
+               .addOption(Opts[Opt.VERSIONS_GECKO])
                .addOption(Opts[Opt.VERSIONS_ANDROID])
                .addOption(Opts[Opt.VERSIONS_APPIUM])
                .addOption(Opts[Opt.CHROME_LOGS])
@@ -108,6 +109,7 @@ function start(options: Options) {
   }
   binaries[StandAlone.id].versionCustom = options[Opt.VERSIONS_STANDALONE].getString();
   binaries[ChromeDriver.id].versionCustom = options[Opt.VERSIONS_CHROME].getString();
+  binaries[GeckoDriver.id].versionCustom = options[Opt.VERSIONS_GECKO].getString();
   if (options[Opt.VERSIONS_IE]) {
     binaries[IEDriver.id].versionCustom = options[Opt.VERSIONS_IE].getString();
   }