This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
Bundle and build using CLI server builder #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
changed the title
mgechev
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 12, 2019
…y expresstion (#15586) In version 9 universal express and hapi `server.ts` will be bundled using the CLI server builder. We need to add this to avoid `the request of a dependency is an expression` warnings See: angular/universal#1237
CaerusKaru
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
LGTM. Some long-needed changes finally going through. Thanks for all this work! Still needs sign-off from @vikerman before it goes through.
vikerman
approved these changes
Sep 16, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits