Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

build: update Bazel to use fine-grained deps #1083

Merged
merged 1 commit into from
Dec 23, 2018
Merged

build: update Bazel to use fine-grained deps #1083

merged 1 commit into from
Dec 23, 2018

Conversation

CaerusKaru
Copy link
Member

No description provided.

@CaerusKaru CaerusKaru added area: build & ci P2: important state: WIP target: minor target: minor This PR is targeted for the next minor release labels Oct 13, 2018
@CaerusKaru CaerusKaru added this to the 6.0 milestone Oct 13, 2018
@CaerusKaru CaerusKaru force-pushed the adam/bazel branch 4 times, most recently from ee78033 to 08aa3d7 Compare October 13, 2018 05:27
@CaerusKaru
Copy link
Member Author

Before I forget, credit for a lot of this goes to @devversion's incredible work over on Material.

@CaerusKaru
Copy link
Member Author

This is blocked on the test step because socket-engine, hapi-engine, and express-engine tests bring in platform-server, which doesn't wire up correctly with domino and xhr2.

@Toxicable Toxicable mentioned this pull request Nov 6, 2018
Closed
@CaerusKaru CaerusKaru force-pushed the adam/bazel branch 14 times, most recently from 2f85ec5 to 0769ab6 Compare December 21, 2018 05:18
@CaerusKaru CaerusKaru force-pushed the adam/bazel branch 15 times, most recently from b6f595e to e8be23a Compare December 23, 2018 03:23
@CaerusKaru CaerusKaru changed the title WIP: build: update Bazel to use fine-grained deps build: update Bazel to use fine-grained deps Dec 23, 2018
Toxicable
Toxicable reviewed Dec 23, 2018
View reviewed changes
integration/common/package.json
"@angular/animations": "file:../../node_modules/@angular/animations",
"@angular/common": "file:../../node_modules/@angular/common",
"@angular/animations": "^7.1.4",
"@angular/common": "^7.1.4",
"@angular/compiler": "file:../../node_modules/@angular/compiler",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are some of these files some version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're no longer installed at the top-level because Angular is now built from source with Bazel

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but there's still a few that are manually installed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there's a reason, but I can't remember what it was. This makes it clear though that these deps are only needed for integration testing.

@CaerusKaru CaerusKaru merged commit 9b83bbe into master Dec 23, 2018
@CaerusKaru CaerusKaru deleted the adam/bazel branch December 23, 2018 04:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Toxicable Toxicable Toxicable approved these changes

@MarkPieszak MarkPieszak Awaiting requested review from MarkPieszak

@vikerman vikerman Awaiting requested review from vikerman

Assignees

@Toxicable Toxicable

Labels
action: review area: build & ci P2: important target: minor target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CaerusKaru @Toxicable @googlebot