Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

WIP: feat(grpc-engine): introduce package #1003

Closed
wants to merge 4 commits into from
Closed

Conversation

Toxicable
Copy link

Similar implementation to #999
But even easier to implement on the other side due to the use of GRPC

@Toxicable
Copy link
Author

Blocked on bazelbuild/rules_typescript#211

@Toxicable Toxicable force-pushed the fabian/grpc-engine branch from 29ffa8e to f7d6228 Compare June 9, 2018 01:49
@CaerusKaru CaerusKaru added comp: grpc-engine target: minor target: minor This PR is targeted for the next minor release action: cleanup and removed state: blocked labels Jun 10, 2018
@Twois
Copy link

Twois commented Aug 27, 2018

Will it land in the near future? - And if will, can we get a more detailed explanation for?

@Toxicable
Copy link
Author

@Twois We're just blocked on a bazel issue, which we have a work around for now so will be able to progrss with it this weekend

@angular angular deleted a comment from googlebot Dec 23, 2018
@angular angular deleted a comment from googlebot Dec 23, 2018
@angular angular deleted a comment from googlebot Dec 23, 2018
@angular angular deleted a comment from googlebot Dec 23, 2018
@angular angular deleted a comment from googlebot Dec 25, 2018
@angular angular deleted a comment from googlebot Dec 25, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@alan-agius4
Copy link
Collaborator

Closing there doesn’t seem to be much interest in this from the community.

Let’s reconsider this, if there is a demand for it.

@dunxen
Copy link

dunxen commented Dec 23, 2019

This would definitely be useful to us. I’m going to take a closer look when I get back home and have reliable interwebz again. 🙂

Hopefully there is a greater interest in this.

@KingDarBoja
Copy link

I was looking at the issue on the ts_proto_library as there is some wrap argument which is being set as amd by default, as it is not documented on the docs. Maybe that could give some insight on how to implement the grpc-engine for the Framework and Platform agnostic Angular Universal rendering proposal.

Cheers!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2020
@kyliau kyliau deleted the fabian/grpc-engine branch March 28, 2020 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: cleanup state: WIP target: minor target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants