Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Multi-argument matchers broken #477

Closed
wants to merge 1 commit into from
Closed

Multi-argument matchers broken #477

wants to merge 1 commit into from

Conversation

konrad-garus
Copy link
Contributor

Jasmine has multi-argument matchers, such as toBeCloseTo. They don't work with the promise wrapper - only the first argument is passed to the actual matcher.

In this test code:

expect(20.0123).toBeCloseTo(20, 0);
var d = protractor.promise.defer();
d.fulfill(20.0123);
expect(d.promise).toBeCloseTo(20, 0);

The first assertion passes, but the second does not (falling back to default, which is 2 decimal places).

Implement support for multi-argument matchers in promise wrapper.

Closes #477
@juliemr
Copy link
Member

juliemr commented Jan 31, 2014

Thanks! Good fixed - merged as de39e50

@juliemr juliemr closed this Jan 31, 2014
juliemr pushed a commit that referenced this pull request Jan 31, 2014
Implement support for multi-argument matchers in promise wrapper.

Closes #477
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants