This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Map function implementation for element.all (v2) #442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple promises Resolve promises if there is an object that contains multiple promises. Added index as a second argument to the map function callback. Closes #392
…ultiple promises Resolve promises if there is an object that contains multiple promises. Added index as a second argument to the map function callback. Closes #392
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| * | ||
| * @param {function(webdriver.WebElement, number)} mapFn Map function that | ||
| * will be applied to each element. | ||
| * @return {!webdriver.promise.Promise} A promise with an array of values |
There was a problem hiding this comment.
I'd say 'A promise that resolves to an array of values...'
…ultiple promises Resolve promises if there is an object that contains multiple promises. Added index as a second argument to the map function callback. Closes #392
|
Done |
|
Automated CLA checker says: please sign CLA at http://code.google.com/legal/individual-cla-v1.0.html Please make sure that the email associated with your PR is the same as the email you use to sign. |
|
Merged! 3151ca7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(locators) Improve the map() function in element.all to resolve multiple promises
Resolve promises if there is an object that contains multiple promises.
Added index as a second argument to the map function callback.
Closes #392