This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
fix(launcher): running getMultiCapabilities should reject on errors #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heathkit
suggested changes
Dec 27, 2016
| }).then(() => resolve()); | ||
| q(config.getMultiCapabilities()) | ||
| .then((multiCapabilities) => { | ||
| console.log('here'); |
sjelin
suggested changes
Dec 27, 2016
| @@ -112,7 +112,7 @@ let initFn = function(configFile: string, additionalConfig: Config) { | |||
| .then(() => { | |||
|
|
|||
| return q | |||
| .Promise<any>((resolve: Function) => { | |||
| .Promise<any>((resolve: Function, reject: Function) => { | |||
There was a problem hiding this comment.
Should be new q.Promise(.... Not your fault but please fix anyway
There was a problem hiding this comment.
This is not possible. Setting this to void returns a transpile error. lib/launcher.ts(114,16): error TS2350: Only a void function can be called with the 'new' keyword.
| runProtractor = spawn('node', | ||
| ['bin/protractor', 'spec/errorTest/getMultiCapabilitiesConf.js']); | ||
| output = runProtractor.stderr.toString(); | ||
| console.log(output); |
| framework: 'debugprint', | ||
| getMultiCapabilities: function() { | ||
| return new Promise((resolve) => { | ||
| this.foo.bar = 1; // will fail because this.foo is undefined |
There was a problem hiding this comment.
I'd rather you just threw something
cnishina
force-pushed
the
fix_getMultiCapabilities
branch
from
8adadba to
8b78800
Compare
cnishina
force-pushed
the
fix_getMultiCapabilities
branch
from
8b78800 to
ab20e57
Compare
sjelin
approved these changes
Dec 27, 2016
heathkit
approved these changes
Dec 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3875