deps(selenium-webdriver): upgrade to selenium 3 #3781

cnishina · 2016-12-01T21:41:57Z

No description provided.

…bdriver for version 3

…for instanceof

…ecated

- update to selenium-webdriver 3.0.1 - fix expected conditions test - verify basic tests pass

using selenium standalon server 2.53.1 - upgrade to selenium-webdriver 3.0.x requires node version 6+, updating travis and circle yml to use node 6 - firefox 47 works - selenium-webdriver/testing uses the global.it and cannot be reassigned as Protractor's global it. Required to copy some of their code to the lib/frameworks/mocha.js file - WIP: still have tests that are not passing. using selenium standalone server 3.0.x - firefox 49 with gecko driver 0.11.1 does not work - firefox 48 with gecko driver 0.11.1 appears to work for a single test but after it quits, selenium standalone no longer works with firefox. - when firefox 48 exists, logs show the following: ``` 20:01:14.814 INFO - Executing: [delete session: e353fa1b-e266-4ec3-afb3-88f11a82473a]) [GFX1-]: Receive IPC close with reason=AbnormalShutdown [Child 30665] ###!!! ABORT: Aborting on channel error.: file /builds/slave/m-rel-m64-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2052 [Child 30665] ###!!! ABORT: Aborting on channel error.: file /builds/slave/m-rel-m64-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2052 ```

- webdriver.quit throws a no session error - define "quit" at runner.ts similar to restart where the driverprovider calls quit instead of the webdriver

- breakpoint updated to lib/http.js line 432

- removed method WebDriver.prototype.isElementPresent - removed method WebElement.prototype.getRawId

- Chrome requires a ServiceBuilder and to call the Service to createSession - Since this upgrade is still using FF 47, direct connect for Firefox is required to pass "marionette: false" in the capabilities. If you do not pass marionette to false, it will look for gecko driver in the PATH. - Added a TODO to support FF after 48 with direct connect and gecko driver.

- added TODO to enable tests again.

juliemr · 2016-12-01T23:56:07Z

lib/element.ts

@@ -13,8 +13,8 @@ let logger = new Logger('element');

 let WEB_ELEMENT_FUNCTIONS = [
  'click', 'sendKeys', 'getTagName', 'getCssValue', 'getAttribute', 'getText', 'getSize',
-  'getLocation', 'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getOuterHtml',
-  'getInnerHtml', 'getId', 'getRawId', 'serialize', 'takeScreenshot'
+  'getLocation', 'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getId', 'getRawId',


we should remove getRawId too

juliemr · 2016-12-01T23:58:17Z

spec/basic/elements_spec.js

@@ -470,15 +470,13 @@ describe('ElementArrayFinder', function() {
    browser.get('index.html#/form');
    var labels = element.all(by.css('#animals ul li')).map(function(elm) {
      return {
-        text: elm.getText(),
-        inner: elm.getInnerHtml()
+        text: elm.getText()


We should have something else here to make sure multiple promises are waited for. How about elm.getTagName?

Added elm.getTagName to the test.

juliemr · 2016-12-02T00:00:24Z

spec/dependencyTest/seleniumWebdriver_spec.js

-    for (var pos1 in WEBDRIVER.staticFunctions) {
-      var staticFunc = WEBDRIVER.staticFunctions[pos1];
-      it('should have a ' + staticFunc + ' function', function() {
+    it('should have static function', function() {


'should have static functions'? (and below)

juliemr · 2016-12-02T00:02:06Z

spec/mocha/lib_spec.js

@@ -42,7 +42,7 @@ describe('protractor library', function() {
      browser.get('index.html').then(function() { finished = true; });
    });

-    after('verify mocha waited', function() {
+    after(function() {


is this a change from Mocha? If not, we should continue to support a description for 'after' if it's a valid Mocha construct.

Added back after('verify mocha waited',

juliemr · 2016-12-02T00:45:03Z

Please make sure that the description for the big commit links to the selenium-webdriver changelog: https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md

and gives a quick heads up about major breaking changes.

juliemr · 2016-12-02T00:48:52Z

spec/dependencyTest/seleniumWebdriver_spec.js

 var SeleniumError = require('selenium-webdriver').error;
 var Remote = require('selenium-webdriver/remote');
 var Testing = require('selenium-webdriver/testing');

 var WEBDRIVER = {
  staticFunctions: ['attachToSession', 'createSession'],
+
  instanceFunctions: ['actions', 'wait', 'sleep', 'getCurrentUrl', 'getTitle',
    'takeScreenshot', 'getSession', 'getCapabilities', 'quit', 'touchActions',


Should we remove 'quit' from here then?

Nevermind, wrong place...

Looks like I got 'quit' to work.

- See [selenium-webdriver changelog](https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md) - Breaking changes including... (something here)

cnishina · 2016-12-02T04:21:08Z

Hooray! 😀 😊

# Upgrade to selenium-webdriver 3.0.1 Note: with the upgrade, there might have breaking changes. Please see the selenium-webdriver changelog. - See [selenium-webdriver changelog](https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md) ### Removed methods - Removed method `WebDriver.prototype.isElementPresent` - Removed method `WebElement.prototype.getRawId` - Removed `getInnerHtml` and `getOutterHtml` ### Dependencies and versions - Dependency required for upgrade: use `[email protected]`. - Selenium-webdriver requires node version 6+, updating travis and circle yml to use node 6 and 7. ### Errors - Use `instanceof` selenium-webdriver error instead of error code. Selenium-webdriver error codes have been deprecated. ### DriverProviders - Use executor with selenium-webdriver from `lib/http`. Deferred executor has been deprecated. - Fix quitting `driverProviders`. When calling `webdriver.quit`, the control flow is shutdown and will throw an error. - Driver provider for direct connect has been modified to use `ServiceBuilder` and to call the `Service` to `createSession` - Note: Since this upgrade is still using FF 47, direct connect for Firefox is required to pass "marionette: false" in the capabilities. If you do not pass marionette to false, it will look for gecko driver in the PATH. - Added a TODO to support FF after 48+ with direct connect and gecko driver. ### Managing Browser - Updated `browser.manage().addCookie('testcookie', 'Jane-1234');` to use `browser.manage().addCookie({name:'testcookie', value: 'Jane-1234'});` ### Debugging - Updated debug commons for breakpoint updated to selenium-webdriver `lib/http` line 432. - Debugger currently does not work. So `elementExplorer` for this current commit does not work. Additional work is required. - Since debugger does not work, interactive tests were disabled in `scripts/tests.js` ### Mocha - For mocha tests, `selenium-webdriver/testing` uses the global `it` and cannot be reassigned as Protractor's global `it`. Some code has been copied / modified to `lib/frameworks/mocha` to make this work. ### Setup Notes: - Capabilities for Firefox 47 requires setting marionette to false. - Setup still requires selenium standalone server 2.53.1 for Firefox tests. Firefox version used is 47. - Using selenium standalone server 3, with Firefox 48+ tests fail with gecko driver still do not work. - Selenium standalone 3 + FF 49 + gecko driver 0.11.1 does not work - Selenium standalone 3 + FF 48 + gecko driver 0.11.1 appears to work for a single test but after it quits, selenium standalone no longer works with firefox. When firefox 48 exists, logs show the following: ``` 20:01:14.814 INFO - Executing: [delete session: e353fa1b-e266-4ec3-afb3-88f11a82473a]) [GFX1-]: Receive IPC close with reason=AbnormalShutdown [Child 30665] ###!!! ABORT: Aborting on channel error.: file /builds/slave/m-rel-m64-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2052 [Child 30665] ###!!! ABORT: Aborting on channel error.: file /builds/slave/m-rel-m64-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2052 ```

Note: with the upgrade, there might have breaking changes. Please see the selenium-webdriver changelog. - See [selenium-webdriver changelog](https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md) - Removed method `WebDriver.prototype.isElementPresent` - Removed method `WebElement.prototype.getRawId` - Removed `getInnerHtml` and `getOutterHtml` - Dependency required for upgrade: use `[email protected]`. - Selenium-webdriver requires node version 6+, updating travis and circle yml to use node 6 and 7. - Use `instanceof` selenium-webdriver error instead of error code. Selenium-webdriver error codes have been deprecated. - Use executor with selenium-webdriver from `lib/http`. Deferred executor has been deprecated. - Fix quitting `driverProviders`. When calling `webdriver.quit`, the control flow is shutdown and will throw an error. - Driver provider for direct connect has been modified to use `ServiceBuilder` and to call the `Service` to `createSession` - Note: Since this upgrade is still using FF 47, direct connect for Firefox is required to pass "marionette: false" in the capabilities. If you do not pass marionette to false, it will look for gecko driver in the PATH. - Added a TODO to support FF after 48+ with direct connect and gecko driver. - Updated `browser.manage().addCookie('testcookie', 'Jane-1234');` to use `browser.manage().addCookie({name:'testcookie', value: 'Jane-1234'});` - Updated debug commons for breakpoint updated to selenium-webdriver `lib/http` line 432. - Debugger currently does not work. So `elementExplorer` for this current commit does not work. Additional work is required. - Since debugger does not work, interactive tests were disabled in `scripts/tests.js` - For mocha tests, `selenium-webdriver/testing` uses the global `it` and cannot be reassigned as Protractor's global `it`. Some code has been copied / modified to `lib/frameworks/mocha` to make this work. - Capabilities for Firefox 47 requires setting marionette to false. - Setup still requires selenium standalone server 2.53.1 for Firefox tests. Firefox version used is 47. - Using selenium standalone server 3, with Firefox 48+ tests fail with gecko driver still do not work. - Selenium standalone 3 + FF 49 + gecko driver 0.11.1 does not work - Selenium standalone 3 + FF 48 + gecko driver 0.11.1 appears to work for a single test but after it quits, selenium standalone no longer works with firefox. When firefox 48 exists, logs show the following: ``` 20:01:14.814 INFO - Executing: [delete session: e353fa1b-e266-4ec3-afb3-88f11a82473a]) [GFX1-]: Receive IPC close with reason=AbnormalShutdown [Child 30665] ###!!! ABORT: Aborting on channel error.: file /builds/slave/m-rel-m64-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2052 [Child 30665] ###!!! ABORT: Aborting on channel error.: file /builds/slave/m-rel-m64-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2052 ``` To be squashed - fix up attach session typo

cnishina added 14 commits December 1, 2016 13:37

deps(selenium-webdriver): update to webdriver-manager and selenium-we…

0467bf3

…bdriver for version 3

upgrade(executor): create a new executor with http

b7c60a2

upgrade(error): error codes in webdriver have been deprecated, check …

c84d9eb

…for instanceof

deps(jasminewd): upgrade to [email protected]

967893e

upgrade(innerHtml): update element spec since innerHtml has been depr…

fc9523c

…ecated

chore(ExpectedConditions): use instanceof for NoSuchAlertError

120d30f

- update to selenium-webdriver 3.0.1 - fix expected conditions test - verify basic tests pass

chore(test): interaction tests

94e7063

- webdriver.quit throws a no session error - define "quit" at runner.ts similar to restart where the driverprovider calls quit instead of the webdriver

chore(tests): interactive tests

4827724

- breakpoint updated to lib/http.js line 432

chore(test): update dependency test

1d75e78

- removed method WebDriver.prototype.isElementPresent - removed method WebElement.prototype.getRawId

chore(interactive): repl failures. wip

ed993b1

chore(tests): fix addCookie for restart browser between tests

d1df714

chore(tests): repl failures WIP

88478c5

googlebot added the cla: yes label Dec 1, 2016

cnishina mentioned this pull request Dec 1, 2016

Selenium 3 upgrade #3743

Closed

chore(tests): disable interactive tests until debugger works

47ca5da

- added TODO to enable tests again.

cnishina force-pushed the selenium3 branch from ea01ebe to 47ca5da Compare December 1, 2016 22:31

cnishina added the pr: needs review label Dec 1, 2016

docs(selenium-webdriver): remove getRawId from doc generation

1ea9d79

cnishina assigned juliemr Dec 1, 2016

juliemr reviewed Dec 2, 2016

View reviewed changes

juliemr added the pr: needs cleanup label Dec 2, 2016

address comments

2470408

cnishina force-pushed the selenium3 branch from a503e2d to 2470408 Compare December 2, 2016 00:33

juliemr approved these changes Dec 2, 2016

View reviewed changes

juliemr added pr: LGTM and removed pr: needs cleanup pr: needs review labels Dec 2, 2016

juliemr reviewed Dec 2, 2016

View reviewed changes

fix browser quit

45f2540

- See [selenium-webdriver changelog](https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md) - Breaking changes including... (something here)

cnishina force-pushed the selenium3 branch from a9cad6a to 45f2540 Compare December 2, 2016 01:01

cnishina merged commit 7b99045 into angular:beta Dec 2, 2016

sjelin mentioned this pull request Jan 25, 2017

Fix "mochawd" to work without the control flow #3985

Closed

cnishina deleted the selenium3 branch November 5, 2018 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps(selenium-webdriver): upgrade to selenium 3 #3781

deps(selenium-webdriver): upgrade to selenium 3 #3781

cnishina commented Dec 1, 2016

juliemr Dec 1, 2016

cnishina Dec 2, 2016

juliemr Dec 1, 2016

cnishina Dec 2, 2016

juliemr Dec 2, 2016

juliemr Dec 2, 2016

cnishina Dec 2, 2016

juliemr commented Dec 2, 2016

juliemr Dec 2, 2016

juliemr Dec 2, 2016

cnishina Dec 2, 2016

juliemr Dec 2, 2016

cnishina commented Dec 2, 2016 •

edited

Loading

deps(selenium-webdriver): upgrade to selenium 3 #3781

deps(selenium-webdriver): upgrade to selenium 3 #3781

Conversation

cnishina commented Dec 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juliemr commented Dec 2, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cnishina commented Dec 2, 2016 • edited Loading

cnishina commented Dec 2, 2016 •

edited

Loading