Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button docs example differs from specification #9360

Closed
kiwikern opened this issue Jan 12, 2018 · 3 comments · Fixed by #9376
Closed

Button docs example differs from specification #9360

kiwikern opened this issue Jan 12, 2018 · 3 comments · Fixed by #9376
Assignees
@devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@kiwikern
Copy link

kiwikern commented Jan 12, 2018 •
edited
Loading

Bug, feature request, or proposal:

Docs bug

What is the expected behavior?

Per specification, FABs should have the accent color if no color attribute is given. Embedded example in the docs shows the Basic FAB in white.
Buttons example should look the same in stackblitz and the embedded docs version.

What is the current behavior?

  • On stackblitz: FAB button without a color attribute is in the accent color as specified.
    image
  • In docs: FAB button without a color attribute has no background. (Basic).
    image
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jan 12, 2018
@ravishivt
Copy link

Same issue for my local project. My fab buttons have no color attribute and in non-prod builds, the buttons are correctly styled with accent palette. But during angular-cli production builds, the fab buttons have no default color.

@devversion
Copy link
Member

devversion commented Jan 13, 2018 •
edited
Loading

I'm looking into this. It looks like something in the production pipeline of the Angular CLI removes some necessary code (looks like the build-optimizer in combination with uglify)

with build-optimizer disabled
image

_with build-optimizer enabled
image

@devversion devversion mentioned this issue Jan 13, 2018
Closed
devversion added a commit to devversion/material2 that referenced this issue Jan 13, 2018
@devversion
fix(button): accent color not set on fab buttons with build optimizer
897062c 
When running an Angular application in production mode with the build optimizer and the Angular CLI, the code part, that sets the default color for round buttons, is removed accidentally.

This seems to be an issue, that's caused by the build optimizer: angular/devkit#388.

Fixes angular#9360
@devversion devversion mentioned this issue Jan 13, 2018
Merged
devversion added a commit to devversion/material2 that referenced this issue Jan 13, 2018
@devversion
fix(button): accent color not set on fab buttons with build optimizer
10804d1 
When running an Angular application in production mode with the build optimizer and the Angular CLI, the code part, that sets the default color for round buttons, is removed accidentally.

This seems to be an issue, that's caused by the build optimizer: angular/devkit#388.

Fixes angular#9360
jelbourn pushed a commit that referenced this issue Jan 21, 2018
@devversion @jelbourn
fix(button): accent color not set on fab buttons with build optimizer
f6bd3fb 
When running an Angular application in production mode with the build optimizer and the Angular CLI, the code part, that sets the default color for round buttons, is removed accidentally.

This seems to be an issue, that's caused by the build optimizer: angular/devkit#388.

Fixes #9360
jelbourn pushed a commit that referenced this issue Jan 23, 2018
@devversion @jelbourn
fix(button): accent color not set on fab buttons with build optimizer (…
b3f8a42 
…#9376)

When running an Angular application in production mode with the build optimizer and the Angular CLI, the code part, that sets the default color for round buttons, is removed accidentally.

This seems to be an issue, that's caused by the build optimizer: angular/devkit#388.

Fixes #9360
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 29, 2018
@devversion @jelbourn
fix(button): accent color not set on fab buttons with build optimizer (…
f6a59cd 
…angular#9376)

When running an Angular application in production mode with the build optimizer and the Angular CLI, the code part, that sets the default color for round buttons, is removed accidentally.

This seems to be an issue, that's caused by the build optimizer: angular/devkit#388.

Fixes angular#9360
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(button): accent color not set on fab buttons with build optimizer devversion/material2
4 participants
@jelbourn @kiwikern @ravishivt @devversion