fix(button): accent color not set on fab buttons with build optimizer #9376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
When running an Angular application in production mode with the build optimizer and the Angular CLI, the code part, that sets the default color for round buttons, is removed accidentally. This seems to be an issue, that's caused by the build optimizer: angular/devkit#388. Fixes angular#9360
devversion
force-pushed
the
fix/button-accent-color-build-optimizer
branch
from
897062c
to
10804d1
Compare
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
…angular#9376) When running an Angular application in production mode with the build optimizer and the Angular CLI, the code part, that sets the default color for round buttons, is removed accidentally. This seems to be an issue, that's caused by the build optimizer: angular/devkit#388. Fixes angular#9360
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running an Angular application in production mode with the build optimizer and the Angular CLI, the code part, that sets the default color for round buttons, is removed accidentally.
This seems to be an issue, that's caused by the build optimizer: angular/devkit#388.
As a workaround we can just switch away from that "logical OR" property assignment. While being at it, the code can be simplified and moved to the main button logic.
Note: I checked if there are more such cases in the Angular Material project, but I was only finding a similar code in the paginator, but I confirmed that this is not an issue. since it's not an assignment, nor in the
constructor.Fixes #9360