fix(aria-describer): server-side rendering error during cleanup #8903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a potential server-side rendering error when the `AriaDescriber` is being cleaned up. Fixes angular#8901.
googlebot
added
the
cla: yes
leo6104
reviewed
Dec 11, 2017
| @@ -147,8 +146,10 @@ export class AriaDescriber { | |||
|
|
|||
| /** Deletes the global messages container. */ | |||
| private _deleteMessagesContainer() { | |||
| this._document.body.removeChild(messagesContainer!); | |||
| messagesContainer = null; | |||
| if (messagesContainer && messagesContainer.parentNode) { | |||
There was a problem hiding this comment.
if (messagesContainer && messagesContainer.parentNode) {
messagesContainer.parentNode.removeChild(messagesContainer);
messagesContainer = null;
}
if messagesContainer.parentNode is not defined and messagesContainer is not null object,
messagesContainer cannot be null.
if (messagesContainer) {
if (messagesContainer.parentNode) {
messagesContainer.parentNode.removeChild(messagesContainer);
}
messagesContainer = null;
}
jelbourn
added
pr: lgtm
action: merge
andrewseguin
added
the
target: patch
andrewseguin
pushed a commit
that referenced
this pull request
Dec 19, 2017
Fixes a potential server-side rendering error when the `AriaDescriber` is being cleaned up. Fixes #8901.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a potential server-side rendering error when the
AriaDescriberis being cleaned up.Fixes #8901.