-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AriaDescriber.ngOnDestory() make SSR 500 error. #8901
Comments
It is regression issue. after 5.0.0-rc.1 , this issue exists. |
Fixes a potential server-side rendering error when the `AriaDescriber` is being cleaned up. Fixes angular#8901.
@leo6104 I wasn't able to reproduce it by injecting the describer, adding a message and then destroying it manually. Looking at your stack trace it seems as if the describer is being removed multiple times. I've submitted a PR with some extra checks around it. |
@crisbeto thank you for pull request!
I think multiple times remove can be occur like this scenario |
Hmm... I remove MatTooltipModule in AppModule, only import in ProfileModule/PostModule but still throw error in angular/material 5.0.0 latest published version. |
Remove MatTooltipModule from PostModule is temporary solution for me. (import MatTooltipModule one time) |
Fixes a potential server-side rendering error when the `AriaDescriber` is being cleaned up. Fixes #8901.
Fixes a potential server-side rendering error when the `AriaDescriber` is being cleaned up. Fixes #8901.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
AriaDescriber should not throw error.
What is the current behavior?
In Universal http request, sometimes server.js throw Error like this.
What are the steps to reproduce?
Sorry for not providing reproduction. It occur not always. (intermittently occur)
What is the use-case or motivation for changing an existing behavior?
It is regression issue because this 500 error seen after angular material upgrade
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 5.1.0
Material 5.0.0 latest
Is there anything else we should know?
I think f6cb2c6#diff-1f285a8492b86390f8e4fe94cf69d7e6R147
This refactor commit ( @crisbeto ) might be the root cause.
Please check for this.. @crisbeto I have to solve this problem for our company's production website.
The text was updated successfully, but these errors were encountered: