Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): make @Output names consistent #6677 #8052

Merged
merged 2 commits into from
Oct 30, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Oct 26, 2017

This is a clean cut of this PR #7160

@amcdnl amcdnl self-assigned this Oct 26, 2017
@amcdnl amcdnl requested a review from jelbourn October 26, 2017 18:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2017
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 26, 2017
…lect-output-6677

# Conflicts:
#	src/lib/select/select.ts
@mmalerba mmalerba merged commit f59abdb into angular:master Oct 30, 2017
@amcdnl amcdnl deleted the select-output-6677 branch November 1, 2017 15:42
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 29, 2018
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 29, 2018
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 29, 2018
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 30, 2018
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
andrewseguin pushed a commit that referenced this pull request Jun 5, 2018
A while ago we made the output names of components consistent (e.g. #8053 and #8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
andrewseguin pushed a commit that referenced this pull request Jun 7, 2018
A while ago we made the output names of components consistent (e.g. #8053 and #8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jun 30, 2018
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants