Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): make @Output names consistent #6677 #8053

Merged
merged 4 commits into from
Oct 30, 2017
Merged

fix(menu): make @Output names consistent #6677 #8053

merged 4 commits into from
Oct 30, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Oct 26, 2017

Clean PR of #7133

@amcdnl amcdnl self-assigned this Oct 26, 2017
@amcdnl amcdnl requested a review from jelbourn October 26, 2017 19:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2017
@amcdnl amcdnl mentioned this pull request Oct 26, 2017
Closed
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 26, 2017
jelbourn
jelbourn reviewed Oct 26, 2017
View reviewed changes
src/lib/menu/menu-panel.ts Outdated
@@ -15,7 +15,7 @@ export interface MatMenuPanel {
yPosition: MenuPositionY;
overlapTrigger: boolean;
templateRef: TemplateRef<any>;
close: EventEmitter<void | 'click' | 'keydown'>;
closed: EventEmitter<void | 'click' | 'keydown'>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presubmit has revealed that this is a problem. Many teams implement MatMenuPanel, so changing this to close breaks them. This one alone should be changed back to closed (aliasing it for the directive)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I switched that interface back to close and kept the alias for close to closed in the directive. Let me know if that is what you were thinking.

@jelbourn jelbourn added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Oct 26, 2017
@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged and removed presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged action: merge The PR is ready for merge by the caretaker labels Oct 27, 2017
@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged labels Oct 30, 2017
@mmalerba mmalerba merged commit b2dd17a into angular:master Oct 30, 2017
@amcdnl amcdnl deleted the menu-output-6677 branch October 30, 2017 21:26
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 29, 2018
@crisbeto
refactor(dialog): normalize event names
4ec8f99 
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 29, 2018
@crisbeto
refactor(dialog): normalize event names
a95d7bc 
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 29, 2018
@crisbeto
refactor(dialog): normalize event names
7b0657b 
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
@crisbeto crisbeto mentioned this pull request May 29, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 30, 2018
@crisbeto
refactor(dialog): normalize event names
a06ea8c 
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
andrewseguin pushed a commit that referenced this pull request Jun 5, 2018
@crisbeto @andrewseguin
refactor(dialog): normalize event names
a119d73 
A while ago we made the output names of components consistent (e.g. #8053 and #8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
andrewseguin pushed a commit that referenced this pull request Jun 7, 2018
@crisbeto @andrewseguin
refactor(dialog): normalize event names
5fa1d5f 
A while ago we made the output names of components consistent (e.g. #8053 and #8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jun 30, 2018
@crisbeto
refactor(dialog): normalize event names
27e170a 
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

Assignees

@amcdnl amcdnl

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amcdnl @jelbourn @googlebot @mmalerba