-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepper does not follow the material guidelines. #7260
Comments
Can you be more specific? Which guidelines in particular does it fail to address? |
Current implementation just seems wrong due to its many errors, that's why I checked the material guidelines. |
Thanks. It's hard to "complete" an issue like this without explicit goals to measure against. |
Aligns the stepper appearance closer to the spec by: * Removing the focused background when focused by mouse. Now it only shows up for programmatic and keyboard focus. * Adding ripples to the step header. * Using a slightly heavier font font the active step. * Using `cursor: pointer` to show that the step is clickable. Fixes angular#7260.
@crisbeto I see that the issue will be closed but I can't find where your fixed the text color [Steps' labels default color is 87% black (currently unfocused labels are 38% black which means 'disabled text' according to material guidelines)]. Did you fixed it? Thank you. |
@Ploppy3 I didn't change it, because the spec seems to indicate that the inactive steps are supposed to be 38% black:
|
38% black means 'disabled text' but you can click on those right? Unless it is a linear stepper. |
The way I interpret it is that disabled text is 38%, but that color isn't reserved only for disabled text. Also AFAIK aside from the orientation, the styling of vertical and horizontal steppers is exactly the same. |
@crisbeto updated my latest comment with a lot more info so I think I should give you another notification :) |
Aligns the stepper appearance closer to the spec by: * Removing the focused background when focused by mouse. Now it only shows up for programmatic and keyboard focus. * Adding ripples to the step header. * Using a slightly heavier font font the active step. * Using `cursor: pointer` to show that the step is clickable. Fixes angular#7260.
Aligns the stepper appearance closer to the spec by: * Removing the focused background when focused by mouse. Now it only shows up for programmatic and keyboard focus. * Adding ripples to the step header. * Using a slightly heavier font font the active step. * Using `cursor: pointer` to show that the step is clickable. Fixes #7260.
@crisbeto Did you fix the last thing we talked about? |
I didn't have time to get around to it, before it got merged @Ploppy3. |
Should I reopen or open a new issue? |
Let's reopen it. |
No longer displays steps as disabled in non-linear mode. Previously they would be greyed-out, causing them to look disabled even though they're clickable. Fixes angular#7260.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Request
What is the expected behavior?
Stepper should follow the material guidelines.
What is the current behavior?
Stepper does not follow the material guidelines.
What is the use-case or motivation for changing an existing behavior?
Stepper should follow the material guidelines.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
2.0.0-beta.11
Is there anything else we should know?
https://material.io/guidelines/components/steppers.html
The text was updated successfully, but these errors were encountered: